Fix the MenuItem sort order icon and improve the accessibility for it

changed milestone to %3.5.x

added UI UX a11y labels

requested review from @Skantes

assigned to @Aza

marked this merge request as draft

added 1 commit

• e45f92cf - Fix the MenuItem sort order icon and improve the accessibility for it

Compare with previous version

marked this merge request as ready

added 15 commits

• e45f92cf...94b38581 - 14 commits from branch videolan:master
• a3fc0bd1 - Fix the MenuItem sort order icon and improve the accessibility for it

Compare with previous version

merged

@Aza @Skantes

This changes lead to crash:

org.videolan.vlc.debug E/VLC/VlcCrashHandler: java.lang.NoSuchMethodError: No interface method setContentDescription(Ljava/lang/CharSequence;)Landroid/view/MenuItem; in class Landroid/view/MenuItem; or its super classes (declaration of 'android.view.MenuItem' appears in /system/framework/framework.jar:classes2.dex)
        at org.videolan.vlc.gui.helpers.UiTools.appendSortOrder(UiTools.kt:623)
        at org.videolan.vlc.gui.helpers.UiTools.updateSortTitles(UiTools.kt:599)
        at org.videolan.vlc.gui.browser.BaseBrowserFragment.onPrepareOptionsMenu(BaseBrowserFragment.kt:137)
        at org.videolan.vlc.gui.browser.FileBrowserFragment.onPrepareOptionsMenu(FileBrowserFragment.kt:137)
        at androidx.fragment.app.Fragment.performPrepareOptionsMenu(Fragment.java:3144)
        at androidx.fragment.app.FragmentManager.dispatchPrepareOptionsMenu(FragmentManager.java:2923)
        at androidx.fragment.app.FragmentController.dispatchPrepareOptionsMenu(FragmentController.java:414)
        at androidx.fragment.app.FragmentActivity.onPreparePanel(FragmentActivity.java:447)
        at androidx.appcompat.view.WindowCallbackWrapper.onPreparePanel(WindowCallbackWrapper.java:99)
        at androidx.appcompat.app.AppCompatDelegateImpl$AppCompatWindowCallback.onPreparePanel(AppCompatDelegateImpl.java:3149)
        at androidx.appcompat.app.ToolbarActionBar.populateOptionsMenu(ToolbarActionBar.java:459)
        at androidx.appcompat.app.ToolbarActionBar$1.run(ToolbarActionBar.java:58)
        at android.os.Handler.handleCallback(Handler.java:739)
        at android.os.Handler.dispatchMessage(Handler.java:95)
        at android.os.Looper.loop(Looper.java:158)
        at android.app.ActivityThread.main(ActivityThread.java:7225)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120)
        at Android.MODEL(SM-N910C)
        at Android.VERSION(6.0.1)
        at Android.FINGERPRINT(samsung/treltexx/trelte:6.0.1/MMB29K/N910CXXS2DRI3:user/release-keys)

"Call requires API level 26 (current min is 17): android.view.MenuItem#setContentDescription"

mentioned in merge request !1417 (merged)

resolved all threads