Skip to content
Snippets Groups Projects

Change the way we display the permission granting in the onboarding

Merged Nicolas Pomepuy requested to merge Aza/vlc-android:onboarding into master
Edited by Nicolas Pomepuy

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Nicolas Pomepuy

      I couldn't find a way to set the full access permission after choosing media permission, and dismissing the snackbar and checking the "don't ask again". Do we let the user fiddle in the android settings to manually reset the full access permission ?

    • Resolved by Nicolas Pomepuy

      For the explanations to be more user accessible, I would change their wording to

      
      You will only be able to auto-discover standard media files
      
      You will be able to auto-discover all your files to play all types of media even weird ones, or compressed files
    • Please register or sign in to reply
  • added 1 commit

    • b47be50f - Add onboarding permissions icons

    Compare with previous version

  • Nicolas Pomepuy added 24 commits

    added 24 commits

    • b47be50f...e7c962a9 - 20 commits from branch videolan:master
    • 27db7421 - Onboarding: rework navigation
    • ad02a64f - Change the way we display the permission granting in the onboarding
    • 722d39ba - Add onboarding permissions icons
    • 2f0bfde1 - Onboarding: import new icons and wording

    Compare with previous version

  • Nicolas Pomepuy added 3 commits

    added 3 commits

    • 855d1ff2 - Change the way we display the permission granting in the onboarding
    • d74522fb - Add onboarding permissions icons
    • f32ea221 - Onboarding: import new icons and wording

    Compare with previous version

  • Nicolas Pomepuy resolved all threads

    resolved all threads

  • added 1 commit

    • 2b0aaaff - Onboarding: fix the permission state when coming back from the no permission fragment

    Compare with previous version

  • Nicolas Pomepuy marked this merge request as ready

    marked this merge request as ready

  • Author Maintainer

    This MR is now ready. All threads have been fixed and I also added a new commit to fix a state issue that I found along the way (when coming back from the no permission fragment, the wrong permission was selected).

  • Nicolas Pomepuy added 2 commits

    added 2 commits

    • aa9ac216 - Implement new onboarding permission screen in landscape mode
    • 0fe91ea9 - Onboarding: improve accessibility

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading