Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • VLC-Android VLC-Android
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 512
    • Issues 512
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VideoLANVideoLAN
  • VLC-AndroidVLC-Android
  • Merge requests
  • !1362

AudioProgress: fix audio sometimes being saved

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Duncan McNamara requested to merge Skantes/vlc-android:resume-audio into master May 02, 2022
  • Overview 6
  • Commits 3
  • Pipelines 3
  • Changes 5

There seems to be a race condition when adding an audio media to history when it starts, in which it doesnt get the right progress, and hence getting the progress saved when it shouldn't. To fix this, a new method was added to media on the medialibrary side, markAsPlayed to increment playcount and add to history but without having to call savePosition / Time.

Edited May 11, 2022 by Duncan McNamara
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: resume-audio

VideoLAN code repository instance