Skip to content

Clarify replay gain preferences

Robert Stone requested to merge rhstone/vlc-android:disable-other-rg-options into master

Description

This MR cleans up the preferences for replay gain based on VLC forum feedback.

Motivation and Context

The three-position replay gain mode (none, track, album) is now separated into two different widgets: an enable/disable checkbox and a mode selector for track or album. The enable/disable checkbox deactivates the other preferences. This clearly indicates to the user if the parameters are used during playback. The extra space also afforded an additional summary line to explain why the default gain will result in quieter tracks. I added an additional line under the default gain which states a gain of 0 disables sound reduction.

How Has This Been Tested?

Tested both the Smartphone and TV interfaces. Modifications appear to work as expected.

  • Enhancement (non-breaking change which cleans up / improves existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING section of the README document.

Merge request reports

VideoLAN code repository instance