Skip to content
Snippets Groups Projects

Speed adjustment and bookmarking for Android Auto podcast mode

Merged Robert Stone requested to merge rhstone/vlc-android:add-podcast-mode-buttons into master
All threads resolved!

Description

This MR builds upon !1132 (merged) to enhance the Android Auto podcast mode. It enables motorists to change speed and bookmark locations during playback.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING section of the README document.
Edited by Robert Stone

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 9b2a8839 - New Playback Speed auto icon

    Compare with previous version

  • added 1 commit

    • 68ba3c97 - Add sources of playback Speed icons with their values

    Compare with previous version

  • added 1 commit

    • e72a5e79 - Add sources of playback Speed icons with their values

    Compare with previous version

  • Robert Stone added 82 commits

    added 82 commits

    • e72a5e79...088d8ae4 - 79 commits from branch videolan:master
    • 2a542b35 - New Playback Speed auto icon
    • 83064986 - Add sources of playback Speed icons with their values
    • 6dca9f57 - Add support for speed adjustment and bookmarking to Android Auto

    Compare with previous version

  • Robert Stone added 3 commits

    added 3 commits

    • a397f740 - Add sources of playback Speed icons with their values
    • 2f0090ba - Add drawable resources for playback speed and bookmarks
    • 06020c3f - Add support for speed adjustment and bookmarking to Android Auto

    Compare with previous version

  • Robert Stone marked this merge request as ready

    marked this merge request as ready

  • Robert Stone resolved all threads

    resolved all threads

    • Resolved by Alexandre Perraud

      It's working well. I think we should change the bookmark icon to this one though. Right now, it is not clear what the button is doing as a tap on it has no return.

      I guess it's not possible to display something when a bookmark is added?

      I also found a UX issue with this:

      • I'm on my car and I play a podcast
      • Then change the speed to 2.00x
      • Then I ask my passenger to enqueue a music track from my mobile device
      • At this point, it's not possible anymore to change the speed back to 1.00x on the auto HUD

      Maybe we should always display the speed icon if it's not 1.00x? In the overflow menu in that case.

      Screenshots with that state:

      device-2021-11-05-074056 speed_issue

  • Robert Stone added 3 commits

    added 3 commits

    • 90ce51b4 - Add drawable resources for playback speed and bookmarks
    • f8c89238 - Show messages in the subtitle if seek fails
    • 13660417 - Add support for speed adjustment and bookmarking to Android Auto

    Compare with previous version

  • Robert Stone marked this merge request as draft

    marked this merge request as draft

  • Robert Stone marked this merge request as ready

    marked this merge request as ready

  • Robert Stone added 7 commits

    added 7 commits

    • 13660417...8bf1753c - 2 commits from branch videolan:master
    • a149293a - New Playback Speed auto icon
    • f341f11e - Add sources of playback Speed icons with their values
    • 4ebc4408 - Add drawable resources for playback speed and bookmarks
    • ab43b879 - Show messages in the subtitle if seek fails
    • e054f363 - Add support for speed adjustment and bookmarking to Android Auto

    Compare with previous version

  • Nicolas Pomepuy resolved all threads

    resolved all threads

  • Nicolas Pomepuy added 6 commits

    added 6 commits

    • 06fff26c - 1 commit from branch videolan:master
    • 27f8e5cb - New Playback Speed auto icon
    • eab8e13a - Add sources of playback Speed icons with their values
    • e66b23ef - Add drawable resources for playback speed and bookmarks
    • 1fbfe869 - Show messages in the subtitle if seek fails
    • f0fbdc2c - Add support for speed adjustment and bookmarking to Android Auto

    Compare with previous version

  • Nicolas Pomepuy enabled an automatic merge when the pipeline for f0fbdc2c succeeds

    enabled an automatic merge when the pipeline for f0fbdc2c succeeds

  • Jean-Baptiste Kempf changed milestone to %3.4.x

    changed milestone to %3.4.x

  • Please register or sign in to reply
    Loading