Skip to content

Small beta bugfixes

Robert Stone requested to merge rhstone/vlc-android:track-info-media-release into master

Description

This MR resolves two issues. First, I observed the following error on the console:

E/System: Uncaught exception thrown by finalizer
E/System: java.lang.AssertionError: VLCObject (org.videolan.libvlc.Media) finalized but not natively released (1 refs)
        at org.videolan.libvlc.VLCObject.finalize(VLCObject.java:103)
        at java.lang.Daemons$FinalizerDaemon.doFinalize(Daemons.java:291)
        at java.lang.Daemons$FinalizerDaemon.runInternal(Daemons.java:278)
        at java.lang.Daemons$Daemon.run(Daemons.java:139)
        at java.lang.Thread.run(Thread.java:923)

Unfortunately, the stack trace doesn't lead to a specific location. However, the new track info code seems to be missing release() calls, so I added them.

Second, the cover art and track information was flickering when swiping and/or quickly changing songs. I narrowed it down to the time required to perform the track info lookup. Timing-wise, it was taking between 60ms-100ms to parse current, prev, and next media. Rather than invoking the method inline, I moved the code to perform the lookup in advance of updating the GUI, which minimizes the time spent between removing and adding views.

Motivation and Context

This change resolves a garbage collection issue and flickering during display update.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING section of the README document.

Merge request reports

VideoLAN code repository instance