Skip to content
Snippets Groups Projects
Commit b452bf32 authored by Steve Lhomme's avatar Steve Lhomme
Browse files

add an option to generate and keep PDB files

Similar to how it's done in VLC
parent 907f225a
No related branches found
No related tags found
1 merge request!2[3.0] add an option to generate and keep PDB files
......@@ -73,6 +73,11 @@ axvlc_la_LDFLAGS = -Wl,--kill-at -Wl,$(DATA_axvlc_rc) \
-Wc,--static -Wc,-static-libgcc
axvlc_la_LIBADD = ../common/libvlcplugin_common.la \
$(LIBVLC_LIBS) $(ACTIVEX_LIBS)
if ENABLE_PDB
# libtool magic path
axvlc_la_DATA = .libs/axvlc.pdb
axvlc_ladir = /lib
endif
DATA_axvlc_rc = $(noinst_axvlc_rc_DATA)
......
......@@ -280,6 +280,20 @@ AS_IF([ test "x$gtk_found" = "xyes" ],
AM_CONDITIONAL(WITH_GTK, [ test "x$gtk_found" = "xyes" ])
AM_CONDITIONAL(HAVE_XCB, [ test "x$xcb_found" = "xyes" ])
vlc_build_pdb=0
AC_ARG_ENABLE([pdb],
AS_HELP_STRING([--enable-pdb],
[Build PDB files for windows targets (default off)]))
AS_IF([test "${SYS}" = "mingw32"],[
AS_IF([test "${enable_pdb}" = "yes"], [
vlc_build_pdb=1
AX_APPEND_FLAG([-g -gcodeview],[CFLAGS])
  • Developer

    This fails builds of 3.0.x for me - it looks like npapi-vlc needs a copy of vlc.git's m4/ax_append_flag.m4.

  • Author Developer

    What is the error you get ?

    Also what version of aclocal are you using ? I'm using 1.15 and the m4 file is found in /usr/share/aclocal/ax_append_link_flags.m4

  • Developer

    I'm getting

    ./configure: line 18569: syntax error near unexpected token `-g'
    ./configure: line 18569: `    AX_APPEND_FLAG(-g -gcodeview,CFLAGS)'
    make[1]: *** [npapi-vlc/Makefile] Error 2

    And I'm building in a bare ubuntu docker image, that so far had everything a VLC build needed (and the rest was supplied by extras/tools). That file seems to be provided by another package than the ones installed so far. aclocal is 1.16.1 provided by extras/tools.

    In vlc.git, a bunch of these m4 files are bundled in the m4 subdir to avoid needing to have them around in the build system, so we should do the same here (there's already an m4 subdir containing some of them here).

  • Author Developer

    Does this work for you ? !4 (merged)

  • Developer

    Looks good to me, can test later today. (This is a bit tricky to test when the build process normally checks it out just before building it.)

  • Author Developer

    yes, I had to modify the git where it gets the code to test all this :/

  • Please register or sign in to reply
AX_APPEND_FLAG([-g -gcodeview],[CXXFLAGS])
LDFLAGS="${LDFLAGS} -Wl,-pdb="
],[])
])
AM_CONDITIONAL([ENABLE_PDB], [test "$vlc_build_pdb" = "1"])
dnl
dnl final flags for ActiveX
AM_COND_IF([HAVE_WIN32], [
......
......@@ -41,6 +41,11 @@ npvlc_la_SOURCES = $(libvlcplugin_la_SOURCES)
npvlc_la_DEPENDENCIES = $(libvlcplugin_la_DEPENDENCIES)
npvlc_la_LIBADD = $(libvlcplugin_la_LIBADD)
npvlc_la_LDFLAGS = $(libvlcplugin_la_LDFLAGS)
if ENABLE_PDB
# libtool magic path
npvlc_la_DATA = .libs/npvlc.pdb
npvlc_ladir = /lib
endif
npapi-sdk:
wget https://storage.googleapis.com/google-code-archive-source/v2/code.google.com/npapi-sdk/source-archive.zip
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment