Update SqliteErrors.h
./src/database/SqliteErrors.h:575:22: error: ‘SQLITE_LOCKED_VTAB’ was not declared in this scope
case SQLITE_LOCKED_VTAB:
^~~~~~~~~~~~~~~~~~
./src/database/SqliteErrors.h:575:22: note: suggested alternative: ‘SQLITE_LOCKED’
case SQLITE_LOCKED_VTAB:
^~~~~~~~~~~~~~~~~~
SQLITE_LOCKED
./src/database/SqliteErrors.h:685:22: error: ‘SQLITE_ERROR_SNAPSHOT’ was not declared in this scope
case SQLITE_ERROR_SNAPSHOT:
^~~~~~~~~~~~~~~~~~~~~
./src/database/SqliteErrors.h:685:22: note: suggested alternative: ‘SQLITE_BUSY_SNAPSHOT’
case SQLITE_ERROR_SNAPSHOT:
^~~~~~~~~~~~~~~~~~~~~
SQLITE_BUSY_SNAPSHOT
Edited by Hugo Beauzée-Luyssen
Merge request reports
Activity
Filter activity
Hi,
Thanks for the merge request!
The changes are invalid as such, since the code are not equivalent. Regarding
SQLITE_ERROR_SNAPSHOT
, this error code should not be used as it appears to only be emitted bysqlite3_snapshot_open()
, which we don't use. Another option would be to enclose the exception class & error handling in a#ifdef SQLITE_ENABLE_SNAPSHOT
-
SQLITE_LOCKED_VTAB
is apparently only available starting from sqlite 3.24.0, but we already require 3.25 for some migrations, so I suppose this should be more of aconfigure.ac
change
Edited by Hugo Beauzée-Luyssen-
This MR was superseded by !95 (merged)
Thanks a lot for reporting the issue and offering a patch!
Please register or sign in to reply