MediaLibrary: Set logger before acquiring file lock

File locking will attempt to log on failure (ie: the medialib is already locked). As fc002ae1 removed s_logger null checking, logging before constructing MediaLibrary dereferences nullptr.

approved this merge request

LGTM but will require the CI to work again

added 9 commits

• 050c7d07...9994f1c9 - 8 commits from branch videolan:master
• 4ed3595b - MediaLibrary: Set logger before acquiring file lock

Compare with previous version

changed milestone to %0.12.x

assigned to @chouquette

enabled an automatic merge when the pipeline for 4ed3595b succeeds

unapproved this merge request

I was too quick to approve, most tests don't use the MediaLibrary::create "factory". With your change, most tests end up using a nullptr logger instance.

If there was only the MediaLibrary class involved, the correct fix would probably be to make the constructor private to enforce the create factory function to be used, but there are other media library classes in the context of tests, so that won't work, or it will require a bit of code duplication...

If I'm being honest, I'm not sure what the best way to achieve what you want is :/

aborted the automatic merge because target branch was updated

mentioned in commit asenat/medialibrary@9969d938

added 2 commits

• 9969d938 - tests: Set logger globally in all test cases
• 9bfa1433 - MediaLibrary: Set logger before acquiring file lock

Compare with previous version

You'll need to do the same kind of change (or use the NewMediaLibrary factory) from the tests programs as well (see test/meson.build for the list of the test programs)

mentioned in commit asenat/medialibrary@98706459

added 2 commits

• 98706459 - tests: Set logger globally in all test cases
• 4bc6c06c - MediaLibrary: Set logger before acquiring file lock

Compare with previous version

nit: your first commit references its own MR, that's a bit strange IMO

added 2 commits

• f1386e0b - tests: Set logger globally in all test cases
• 3e54bf76 - MediaLibrary: Set logger before acquiring file lock

Compare with previous version

added 30 commits

• 3e54bf76...5a3fa473 - 28 commits from branch videolan:master
• c04a18f9 - tests: Set logger globally in all test cases
• 974fe366 - MediaLibrary: Set logger before acquiring file lock

Compare with previous version

resolved all threads

approved this merge request

merged