Skip to content
Snippets Groups Projects

tests: Fix data race on vptr

Merged Hugo Beauzée-Luyssen requested to merge chouquette/medialibrary:fix_vptr_race into master

When tearing down MediaLibraryWithDiscoverer, we end up stopping the parser from the media library destructor (not the MediaLibraryWithDiscoverer one) which causes the vptr to be updated to the MediaLibrary one. This will cause the regular getParser overload to be used if the discoverer thread asks for a parser when stopping. By explicitly stopping the discoverer from the test class, we ensure the proper vptr gets used until the discoverer thread joins

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
Please register or sign in to reply
Loading