Add an background task interruption mechanism
This should fix #99 (closed)
We could improve things by also interrupting the various parsers, but that seems to indicate that we need a bigger refactoring. Currently, most parsers are not stateless, and allowing them to be interrupted means we need to store a state in any case.
This means that we can give up on the idea of having multiple threads using a single service, and therefor we can probably simplify the code significantly (at no cost, since we're not using multiple threads for the background workers currently anyway)
Merge request reports
Activity
added 5 commits
- 795bd8e9 - VLCMetadataService: Cosmetics
- 0ad6fcfe - ParserWorker: Stop pretending to support multiple threads per service
- bae6ef2c - VLCMetadataService: Allow preparse to be interrupted
- 3d6caec0 - Thumbnailer: Allow thumbnailers to be interrupted.
- cb83d6b4 - CoreThumbnailer: Reindent after last changes
Toggle commit listAdded support for interrupting thumbnailers (only the core one for now, and vmem most likely won't get it)
This needs !31 (merged) to be merged as we need to erase the failure record in case we cancel a generation.
Ideally this needs testing in VLC before being merged, which also requires !31 (merged) to be merged & the VLC medialib API to be updated.
added 36 commits
-
cb83d6b4...354d8f92 - 30 commits from branch
videolan:master
- bba63a15 - Add an background task interruption mechanism
- ccfc86e0 - VLCMetadataService: Cosmetics
- c5fbf10b - ParserWorker: Stop pretending to support multiple threads per service
- 3b947ad7 - VLCMetadataService: Allow preparse to be interrupted
- f4758a28 - Thumbnailer: Allow thumbnailers to be interrupted.
- c04895f2 - CoreThumbnailer: Reindent after last changes
Toggle commit list-
cb83d6b4...354d8f92 - 30 commits from branch
added 7 commits
-
736dcb42 - 1 commit from branch
videolan:master
- 6ae0e7e1 - Add an background task interruption mechanism
- 26a70323 - VLCMetadataService: Cosmetics
- 3b0caf5d - ParserWorker: Stop pretending to support multiple threads per service
- b5e4fbbe - VLCMetadataService: Allow preparse to be interrupted
- 0f7ac757 - Thumbnailer: Allow thumbnailers to be interrupted.
- ca6ae77e - CoreThumbnailer: Reindent after last changes
Toggle commit list-
736dcb42 - 1 commit from branch
added 6 commits
- 7d00a883 - Add an background task interruption mechanism
- 6684b70f - VLCMetadataService: Cosmetics
- ee970574 - ParserWorker: Stop pretending to support multiple threads per service
- 3185b3ca - VLCMetadataService: Allow preparse to be interrupted
- 5a3f0c76 - Thumbnailer: Allow thumbnailers to be interrupted.
- d9927993 - CoreThumbnailer: Reindent after last changes
Toggle commit listadded 8 commits
- 24b7f0e7 - libvlcpp: Bump version
- 48c36da4 - CoreThumbnailer: Update to VLC API changes
- 9bb23db9 - Add an background task interruption mechanism
- aaa5995a - VLCMetadataService: Cosmetics
- 00b95b2b - ParserWorker: Stop pretending to support multiple threads per service
- d85cb7a2 - VLCMetadataService: Allow preparse to be interrupted
- 5f3e1cab - Thumbnailer: Allow thumbnailers to be interrupted.
- 79f0540c - CoreThumbnailer: Reindent after last changes
Toggle commit listadded 9 commits
-
79f0540c...1b0d68bf - 3 commits from branch
videolan:master
- 885b9266 - Add an background task interruption mechanism
- d28d8f5a - VLCMetadataService: Cosmetics
- 2a334d21 - ParserWorker: Stop pretending to support multiple threads per service
- 8a8cdf6e - VLCMetadataService: Allow preparse to be interrupted
- 65dc68b7 - Thumbnailer: Allow thumbnailers to be interrupted.
- 15739d0f - CoreThumbnailer: Reindent after last changes
Toggle commit list-
79f0540c...1b0d68bf - 3 commits from branch
changed milestone to %0.5.x