Android : Crash after a Clear App Data, just after the onboarding.

It seems also that the crash is triggered when you select Yes for the dialog New External Storage Detected.

But if you wait to click Yes on this dialog (10s), there is no crash.

device-2022-03-15-152744

log.txt

Context

App version

3.5 (Master)

Android version

11.0

Device model

Xperia 10 III

changed milestone to %0.12.0

added bug label

assigned to @chouquette

changed milestone to %0.11.1

changed the description

added Doing label

It seems the issue comes from the main discovery being interrupted and restarted multiple times.

It's likely that the parser queue doesn't get flushed, causing multiple "new" files to be scheduled for analysis, which ends up causing the unique constraint violation.

An easy fix would be to generalize the path that ignores such errors in case of removable media and apply it for non removable media as it turns out it can happen, or maybe we should flush the parser task list when interrupting a reload task?

Actually the parser queue shouldn't be the issue, we first try to insert the task in database, which should fail if a task with an identical MRL is already present. If the insertion fails, we don't schedule the task again.

The first task is executed to completion:

03-21 19:10:08.154 22268 22450 D VLC/medialibrary: [T#510592601280] ../src/metadata_services/MetadataParser.cpp:615 createFileAndMedia Adding file:///storage/emulated/0/VLC_Sample/Video/H264_MP4_850%20METERS%20teaser.mp4
...
03-21 19:10:08.166 22268 22450 D VLC/medialibrary: [T#510592601280] ../src/parser/ParserWorker.cpp:243 mainloop Done executing Metadata task on file:///storage/emulated/0/VLC_Sample/Video/H264_MP4_850%20METERS%20teaser.mp4 in 19ms. Result: 1

(1 is the value corresponding with parser::Status::Success)

however it's executed again immediately after. This seems to be a good example of the (theoretical, so far) issue described in #103

The parser queue isn't the issue, when the android app asks for some entry point ban, we flush & refresh the task list, so this is definitely the issue described in #103

Another thing that would be nice to solve is that if N ban request come in a row (as is the case for the vlc-android app) it's a total waste to flush & refresh the task list N times

mentioned in merge request !634 (merged)

closed with commit 4df3a355

closed with merge request !634 (merged)

removed Doing label