MediaPlayer: fix outputDeviceSet after libvlc API change
The module parameter has been removed in vlc@fd345221
So we just keep the outputDeviceSet() variant that didn't have the module parameter.
Merge request reports
Activity
- Resolved by Steve Lhomme
Hi,
Thanks for addressing this, if you could enable pipelines on your forks so the CI can run?
It should exhibit a build issue with libvlc 3.x since the parameter is still there. You'll most likely need to add a new preprocessor block for 4.x
added 1 commit
- 8f2d580e - MediaPlayer: fix outputDeviceSet after libvlc API change
@chouquette do I need to do anything for it to pick the latest libvlc hash ? Or it's using an uploaded nightly, which fails because libvlcpp fails ? In which case the CI can never pass (I'm pretty sure the code is correct now).
@robUx4 you can now bump the 4.0 image to
registry.videolan.org/libvlcpp-unstable:20220208081312
added 1 commit
- 833d14aa - MediaPlayer: fix outputDeviceSet after libvlc API change
Thanks for fixing this! FYI I just bumped the npapi submodule: npapi-vlc@7e6151f5
This should fix the VLC nightlies