Skip to content
Snippets Groups Projects

[RFC] renderer: enable peak detection by default

Merged Niklas Haas requested to merge haasn/libplacebo:enable_peak into master

It really is impossible to stress how much peak detection improves out-of-the-box HDR tone-mapping. I'd rather hyperoptimize performance on it than keep it disabled.

Merge request reports

Pipeline #360089 passed

Pipeline passed for 6bdb786e on haasn:enable_peak

Test coverage 80.51% (-0.20%) from 1 job
Approval is optional

Merged by Niklas HaasNiklas Haas 1 year ago (Jul 5, 2023 3:26pm UTC)

Merge details

  • Changes merged into with 6bdb786e.
  • Deleted the source branch.

Pipeline #360114 passed

Pipeline passed for 6bdb786e on master

Test coverage 80.51% (-0.20%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Niklas Haas added 1 commit

    added 1 commit

    • bde0852b - renderer: silently disable peak-detection if no SSBOs

    Compare with previous version

  • Niklas Haas added 2 commits

    added 2 commits

    • 63adefb9 - renderer: silently disable peak-detection if no SSBOs
    • 571bc1fd - renderer: enable peak detection by default

    Compare with previous version

  • Niklas Haas changed title from renderer: enable peak detection by default to [RFC] renderer: enable peak detection by default

    changed title from renderer: enable peak detection by default to [RFC] renderer: enable peak detection by default

  • Author Maintainer

    Well, the problem is that this is still brutally difficult for intel iGPUs to handle on anything resembling 4K60...

  • Niklas Haas added 11 commits

    added 11 commits

    • 571bc1fd...187bbbe9 - 2 commits from branch videolan:master
    • d38a3597 - renderer: silently disable peak-detection if no SSBOs
    • b2f58580 - renderer: enable peak detection by default
    • 1bb74e5f - renderer: move skip_caching_single_frame to correct section
    • bf33705d - shaders/colorspace: add pl_*_high_quality_params for tone-mapping
    • 93717c25 - renderer: use pl_*_high_quality_params where appropriate
    • b96775d7 - renderer: don't disable contrast recovery if no downscaler set
    • ebe5107e - renderer: ignore skip_anti_aliasing for contrast recovery
    • f0069f05 - demos/plplay: fix indent (cosmetic)
    • 53f1e0bd - demos/plplay: add -h to enable high-quality preset

    Compare with previous version

  • Author Maintainer

    I decided to split these options into "default" and "high quality" presets, with the more taxing options (histogram measurement and contrast recovery) being relegated to the HQ preset.

    This will regress projects like mpv in the short term, until the appropriate options are mapped there. Will do that after release and dep bump.

  • Author Maintainer

    Indeed, with the current split, we may even consider:

    • enabling allow_delayed by default in pl_peak_detect_params, to be disabled in HQ params
    • using smaller 3DLUT in default color map params, and maybe even slightly larger 3DLUT in high quality params
  • Niklas Haas changed milestone to %v6.283+

    changed milestone to %v6.283+

  • Author Maintainer

    Should re-evaluate this after !495 (merged)

  • Niklas Haas added 14 commits

    added 14 commits

    • 53f1e0bd...fcf81635 - 5 commits from branch videolan:master
    • f382330c - renderer: silently disable peak-detection if no SSBOs
    • 4fd467e3 - renderer: enable peak detection by default
    • f09f8bec - renderer: move skip_caching_single_frame to correct section
    • 15279ff7 - shaders/colorspace: add pl_*_high_quality_params for tone-mapping
    • ae073ccd - renderer: use pl_*_high_quality_params where appropriate
    • 258df5cc - renderer: don't disable contrast recovery if no downscaler set
    • 4736ad21 - renderer: ignore skip_anti_aliasing for contrast recovery
    • 9a73e152 - demos/plplay: fix indent (cosmetic)
    • 1f80b967 - demos/plplay: add -h to enable high-quality preset

    Compare with previous version

  • Niklas Haas added 9 commits

    added 9 commits

    • cbfed1e9 - renderer: silently disable peak-detection if no SSBOs
    • afb9fc8a - renderer: enable peak detection by default
    • d5a74748 - renderer: move skip_caching_single_frame to correct section
    • 5b9937c8 - shaders/colorspace: add pl_*_high_quality_params for tone-mapping
    • 1bcaadb7 - renderer: use pl_*_high_quality_params where appropriate
    • 821a052f - renderer: don't disable contrast recovery if no downscaler set
    • ff7756a7 - renderer: ignore skip_anti_aliasing for contrast recovery
    • 32d2276a - demos/plplay: fix indent (cosmetic)
    • 6bdb786e - demos/plplay: add -h to enable high-quality preset

    Compare with previous version

  • Niklas Haas approved this merge request

    approved this merge request

  • merged

Please register or sign in to reply
Loading