David Rosca authored 1 year ago and Niklas Haas committed 1 year ago

Fixes mapping frames with padding (eg. 1080p ~ 1088).

Not the correct solution, but an improvement on the status quo.

See-Also: #319

Kacper Michajłow authored 1 year ago and Niklas Haas committed 1 year ago

No need to include xxhash dependency in .pc, it is fully inlined.

Small keys break some statistical assumptions inside the cache layer.

This was accidentally included once per sample, as a result of the
anti-ringing code.

See-Also: https://github.com/haasn/libplacebo/issues/217

$id@c can collide with another identifier that has larger $id, add extra
_ to avoid collision.

Fixes: https://github.com/haasn/libplacebo/issues/217

Dudemanguy authored 1 year ago and Niklas Haas committed 1 year ago

pl_icc_update needs to be called every frame, so if libplacebo is
compiled without lcms support, this leads to spam. There's no need to
warn more than once so just keep track of it in a bool.

Dudemanguy authored 1 year ago and Niklas Haas committed 1 year ago

At least for mpv, if we have a playlist of images, fail opening the ICC
of one image, go forward and then back to the image with the ICC
failure, it'll hit this assertion failure. Not so nice. If there's no
ICC information, it just does nothing so display the image as usual.

Kacper Michajłow authored 1 year ago and Niklas Haas committed 1 year ago

This will never be used uninitialized, guarded by use_dbghelp, but GCC
analysis is too shallow and fails to see that.

What does it even mean? You can share a vulkan device just fine..

m154k1 authored 1 year ago and Niklas Haas committed 1 year ago

Testing an element's truth value will raise an exception in future
versions.

Prevent log spam.

Sanity. Don't advertise support for SSBOs/UBOs/etc. if basic buffer
support is not available.

Avoids triggering assertions added by 3bd1c970.

This is not a very elegant solution, by the way. Actually, it would be
better to query the maximum buffer size specifically for use as UBOs
etc, e.g. by allocating a test buffer and querying the driver for its
allowed memory types, then looking at only those memory types.

Makes this actually check the relevant requirements.

This is an insane case to work around, because no GPU backend enables
emulated format without the corresponding buffer support. I'd rather
pl_assert() it than return it as an error to the caller.

(Note that we already hit the slice_w assertion in this case)

OpenGL has emulated texture formats that don't need texel storage buffer
emulation, so support this case also.

Note that this change does not actually do anything yet, but I plan on
re-using this helper in the (near) future.

We only need to use the max SSBO sizee for emulated transfers.
Otherwise, max_buf_size is sufficient.

This helper was failing to account for the pixel stride alignment
requirements.

This accidentally sharpened the frame mixer when the source fps was
below monitor fps.

By one that doesn't have such strict requirements on the texture size.

Unceremoniously stolen from multigpu-bench.

Turn these defines into enums and group them more appropriately, and
make the queue configuration configurable (for testing).

Instead of linearly desaturating, use a third-order polynomial
approximation.

Re-use an existing helper and remove a misleading comment.

We can early-dispatch this callback as soon as we're done mempcying the
data into a temporary buffer.