Skip to content

DVD-Audio: insure DVD type for SAMG IFO in public API + sanity check for ATS title table

Saifelden Mohamedrequested to merge
XHCFS/libdvdread:dvda-samg-guard into master

  1. A type check, since the SAMG IFO doesn't exist in DVD-Video the public API should exit and print a debug statement if you access this option without the correct DVD type.

  2. For ATS title table I added a small sanity check, this checks all the elements up to the pointer records table.

  3. Fixed inconsistent formatting for my IFO Read functions

  4. downmix coefficients were incorrectly represented in the current code, they are not 64 bit numbers but rather a series of coefficients with a total size of 12 bytes and 4 bytes of padding. this is from the unofficial specs, discwelder manual and examples I've seen from hex dumps

additionally, I should mention that discs authored with Discwelder place a downmix coefficient in the SAMG ifo, Though I have not seen this in any commercial disc so I decided not to include it , (Discwelder produced discs can be unreliable)

  1. added public API for ifo reads in dvdaudio, exposed ifoRead_TIF and ifoRead_TT and ifoFree_TT, and made it so ifoOpenVMGI and ifoOpenVTSI will open AMGI and ATSI if the DVDOpenAudio was called instead of DVDOpen, to get the dvd_reader struct

this needed to be adjusted for all the code that used it in one commit so that it compiled

Edited by Saifelden Mohamed

Merge request reports

VideoLAN code repository instance