Draft: pass the buffer size to the bit readers

Similar code as featured in !22 but on top of !28.

Also requires libdvdnav!25

The code found in !22 already cannot overflow but the bitreader can be used with external buffers.

Given the PCI and DSI have fixed sizes we could also force the reader to use that size, since we are changing the API...

Draft until !28 is merged.

added 37 commits

• b49f9f58...f6774c38 - 6 commits from branch videolan:master
• b3a1b81f - add defines for some packed structure sizes
• f127f01b - ifo_read: use packed size when reading bytes
• ddc8f8c9 - ifo_read: remove unused variable write
• 64dfeb5f - ifo_read: read structures via a buffer reader
• 2f21d1c0 - ifo_read: read the VMG using the buffer reader
• 557ed96c - ifo_read: read the PGC using the buffer reader
• 1c219752 - ifo_read: read the PGC Command Table using the buffer reader
• 1a22262e - ifo_read: read the Title SPRT using the buffer reader
• bca05c6f - ifo_read: read the PGCI UT using the buffer reader
• 38876385 - ifo_read: read the PGCIT data using the buffer reader
• 0c2eed15 - ifo_read: read the VTS using the buffer reader
• 9cc33ca5 - ifo_read: read the PGC program map using the buffer reader
• cfcf43f6 - ifo_read: read the Cell Position Table using the buffer reader
• ccdda84f - ifo_read: read the PTT SRPT program map using the buffer reader
• f58d88a8 - ifo_read: read the PTL MAIT program map using the buffer reader
• dad0407b - ifo_read: read the TMAP Table program map using the buffer reader
• deafbf14 - ifo_read: read the ADT program map using the buffer reader
• 18ecb84a - ifo_read: read the VOBU ADMAP program map using the buffer reader
• 6e4c7176 - ifo_read: read the VTS Attributes program map using the buffer reader
• d8c6d6ab - ifo_read: read the ATRT program map using the buffer reader
• 3625f5db - ifo_read: read the TXTDT program map using the buffer reader
• a36c2784 - remove dead code
• 92d54712 - ifo_types: do not pack IFO structures
• df949ce6 - nav_types: do not pack IFO structures
• 3f445997 - ifo_types: remove all structure packing
• 40a5391c - ifo_read: use a helper function to read into a buf_reader
• 4c2958f3 - ifo_read: use a stack-allocated buffer for fixed size buffer reading
• b7c9b8b1 - ifo_read: read dynamic size structures in an allocated buffer
• ada77cac - ifo_read: rework the TTU PGCN/PGN reading
• 1bfde7d9 - nav_read: Pass the buffer size as a 3rd parameter
• 47a4f575 - bitreader: Provide the buffer size

Compare with previous version

added 32 commits

• a627cbc8 - add defines for some packed structure sizes
• 8ec04438 - ifo_read: use packed size when reading bytes
• 15f91c76 - ifo_read: remove unused variable write
• 5ebb07f0 - ifo_read: read structures via a buffer reader
• 20e00865 - ifo_read: read the VMG using the buffer reader
• 9c23bf91 - ifo_read: read the PGC using the buffer reader
• b95aca1e - ifo_read: read the PGC Command Table using the buffer reader
• 7dd0d662 - ifo_read: read the Title SPRT using the buffer reader
• 89012a94 - ifo_read: read the PGCI UT using the buffer reader
• b197c56e - ifo_read: read the PGCIT data using the buffer reader
• 7d75698a - ifo_read: read the VTS using the buffer reader
• 8d5db9bc - ifo_read: read the PGC program map using the buffer reader
• eb497d09 - ifo_read: read the Cell Position Table using the buffer reader
• ea8f35c7 - ifo_read: read the PTT SRPT program map using the buffer reader
• b089f144 - ifo_read: read the PTL MAIT program map using the buffer reader
• 55a28776 - ifo_read: read the TMAP Table program map using the buffer reader
• a62f0ddc - ifo_read: read the ADT program map using the buffer reader
• ff67c521 - ifo_read: read the VOBU ADMAP program map using the buffer reader
• e8f37df6 - ifo_read: read the VTS Attributes program map using the buffer reader
• 0200747c - ifo_read: read the ATRT program map using the buffer reader
• 71021dec - ifo_read: read the TXTDT program map using the buffer reader
• 90b365ce - remove dead code
• 46c326ea - ifo_types: do not pack IFO structures
• ea5f5c01 - nav_types: do not pack IFO structures
• fdda51c1 - ifo_types: remove all structure packing
• 26ff4052 - ifo_read: use a helper function to read into a buf_reader
• de33794e - ifo_read: use a stack-allocated buffer for fixed size buffer reading
• 700678fb - ifo_read: read dynamic size structures in an allocated buffer
• 5db2bf1a - ifo_read: rework the TTU PGCN/PGN reading
• f0d73952 - ifo_types: remove zero values we don't read anymore
• c983cec6 - nav_read: Pass the buffer size as a 3rd parameter
• abced6e5 - bitreader: Provide the buffer size

Compare with previous version

added 36 commits

• abced6e5...0e020921 - 4 commits from branch videolan:master
• 11185527 - add defines for some packed structure sizes
• f9d96196 - ifo_read: use packed size when reading bytes
• 3c79e6fb - ifo_read: remove unused variable write
• 9184c308 - ifo_read: read structures via a buffer reader
• c3e715b5 - ifo_read: read the VMG using the buffer reader
• c40cb6d5 - ifo_read: read the PGC using the buffer reader
• 7d373f4e - ifo_read: read the PGC Command Table using the buffer reader
• 603df6ee - ifo_read: read the Title SPRT using the buffer reader
• bef62d39 - ifo_read: read the PGCI UT using the buffer reader
• 6e1397de - ifo_read: read the PGCIT data using the buffer reader
• 937a1df2 - ifo_read: read the VTS using the buffer reader
• 057294a7 - ifo_read: read the PGC program map using the buffer reader
• b56df745 - ifo_read: read the Cell Position Table using the buffer reader
• 108a87f1 - ifo_read: read the PTT SRPT program map using the buffer reader
• 093beca2 - ifo_read: read the PTL MAIT program map using the buffer reader
• 0e714752 - ifo_read: read the TMAP Table program map using the buffer reader
• e4963e0d - ifo_read: read the ADT program map using the buffer reader
• 099975cb - ifo_read: read the VOBU ADMAP program map using the buffer reader
• 59987205 - ifo_read: read the VTS Attributes program map using the buffer reader
• e940f37a - ifo_read: read the ATRT program map using the buffer reader
• 53e51d58 - ifo_read: read the TXTDT program map using the buffer reader
• e530b205 - remove dead code
• daa22857 - ifo_types: do not pack IFO structures
• cc1a138b - nav_types: do not pack IFO structures
• e51efdac - ifo_types: remove all structure packing
• 47076fa4 - ifo_read: use a helper function to read into a buf_reader
• 62570786 - ifo_read: use a stack-allocated buffer for fixed size buffer reading
• 520ff6dc - ifo_read: read dynamic size structures in an allocated buffer
• 18bddb42 - ifo_read: rework the TTU PGCN/PGN reading
• 8c778de9 - ifo_types: remove zero values we don't read anymore
• 66e4b4cc - nav_read: Pass the buffer size as a 3rd parameter
• 0a804c84 - bitreader: Provide the buffer size

Compare with previous version

changed the description

mentioned in merge request libdvdnav!25

mentioned in merge request !28

mentioned in merge request libdvdnav!50

mentioned in commit robUx4/vlc@c0422b8f

mentioned in merge request vlc!2377 (closed)

mentioned in merge request libdvdnav!51 (closed)