Add automatic thread count selection
Fixes #206 (closed).
Merge request reports
Activity
added feature performance labels
changed milestone to %0.5.1
- Resolved by Henrik Gramner
- Automatically resolved by Henrik Gramner
- Automatically resolved by Henrik Gramner
- Resolved by Henrik Gramner
added 3 commits
-
2a4e1052...3e9f9676 - 2 commits from branch
videolan:master
- e72f9509 - Add automatic thread count selection
-
2a4e1052...3e9f9676 - 2 commits from branch
added 3 commits
-
e72f9509...55951027 - 2 commits from branch
videolan:master
- 95fd3a49 - Add automatic thread count selection
-
e72f9509...55951027 - 2 commits from branch
changed milestone to %0.5.2
Graph of dav1d performance with proposed FT and TT split. There is a jump from 2 to 3 tile threads and 3 to 4 tile threads.
Edited by Nathan E. EggeThat would probably be better, yes, but I think that's out of scope for this MR since it's significantly more complex than just picking some numbers.
So the question is: Should we add some basic intermediary auto thread selection like this until someone rewrites the threading implementation?
I don't think we have to re-write the threading implementation. I think what Nathan is looking for is something where we peek at the first frame's header (since most of the times,
n_tile_cols
doesn't change; if we ever want to support that, we can do it later), and setn_tile_threads
to not be higher thann_tile_cols
. This might mean cachingn_threads
and delaying thread init until beyond the first frame header has been peaked at.added 18 commits
-
95fd3a49...a1647a59 - 17 commits from branch
videolan:master
- fe22a820 - Add automatic thread count selection
-
95fd3a49...a1647a59 - 17 commits from branch
added 30 commits
-
fe22a820...82eda83a - 29 commits from branch
videolan:master
- 1c56d3a8 - Add automatic thread count selection
-
fe22a820...82eda83a - 29 commits from branch
mentioned in merge request !1252 (merged)