Issue #415 : Changed ambigiuous function name
old function name : picture_alloc_with_edges to new function name : alloc_properties_to_picture_with_edges
Merge request reports
Activity
:) This patch mis-understands the context of the afore-mentioned bug report. The issue is that the picture has no edges. The allocation is also done without edges. Therefore, "alloc_picture_with_edges()" is misleading. It should just be called "alloc_picture()".
The fact that a picture has properties or metadata associated with it is not really relevant, they're just an implementation detail. It's common for pictures to have properties and/or metadata associated with it. AVFrame in FFmpeg has side-data, and a picture without width/height/pixfmt would be entirely useless.
And please don't change the indentation. Your coding style changes are not consistent with the coding style.
requested review from @rbultje
As for git commits: the first line should not be that you changed something, but what you changed. E.g.: "picture.c: rename alloc_picture_with_edges() to alloc_picture()". The body can then refer to the bug report where this was mentioned so people reading history have context. This way, people scanning the output of "git log --oneline" (or the web-variant thereof) know what the patch changed, not just that it changed something.
added 2 commits
Superseeded by !1585 (merged).
