Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • dav1d dav1d
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 25
    • Issues 25
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 14
    • Merge requests 14
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VideoLANVideoLAN
  • dav1ddav1d
  • Merge requests
  • !1221

checkasm: Validate the benchmark call configurations even if not benchmarking

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Martin Storsjö requested to merge mstorsjo/dav1d:checkasm-test-bench into master Jun 10, 2021
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

This should help catch issues like the one fixed in 185194be, by making sure that we call the benchmarked function at least once with the given parameters, even if not benchmarking. Otherwise the benchmark codepath is essentially dead untested code until somebody works on that piece of code.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: checkasm-test-bench

VideoLAN code repository instance