Skip to content
Snippets Groups Projects
Commit c6a08b3a authored by Janne Grunau's avatar Janne Grunau
Browse files

build: avoid meson's symbols_have_underscore_prefix

Meson's dynamic check is unreliable when additional compiler flags are
passed via CFLAGS. For example '-fprofile-instr-generate' in oss-fuzz'
coverage build. Fixes #370.
parent 9636af88
No related branches found
No related tags found
1 merge request!1296build: avoid meson's symbols_have_underscore_prefix
Pipeline #140202 passed with stages
in 9 minutes and 7 seconds
...@@ -382,7 +382,11 @@ endif ...@@ -382,7 +382,11 @@ endif
cdata.set10('ARCH_PPC64LE', host_machine.cpu() == 'ppc64le') cdata.set10('ARCH_PPC64LE', host_machine.cpu() == 'ppc64le')
if cc.symbols_have_underscore_prefix() # meson's cc.symbols_have_underscore_prefix() is unfortunately unrelieably
  • Contributor

    There is a spelling error in the comment. The word "unrelieably" should be changed to "unreliable".

  • Please register or sign in to reply
# when additional flags like '-fprofile-instr-generate' are passed via CFLAGS
# see following meson issue https://github.com/mesonbuild/meson/issues/5482
if (host_machine.system() == 'darwin' or
(host_machine.system() == 'windows' and host_machine.cpu_family() == 'x86'))
cdata.set10('PREFIX', true) cdata.set10('PREFIX', true)
cdata_asm.set10('PREFIX', true) cdata_asm.set10('PREFIX', true)
endif endif
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment