Patches: Backport new attachment API

In order to fix vlc-ios#1145 (closed), the decision has been made to backport this patch for the media library.

Indeed, the media library launches a playback to extract the thumbnails with audio, leading to a "noisy parsing" as described in the vlc-ios ticket.

This will ensure a better handling of thumbnails.

Additionally modifications needs to be made on the VLCMediaLibraryKit.

Android related MR:

vlc-android!799 (merged)

cc/ @chouquette

changed milestone to %3.4.0

added iOS label

Breaking the API/ABI for plugins is a bit risky/ugly on the VLCKit side for 3.x, maybe it can be patched by VLC-iOS directly or it can be added in a way the previous API is not changed? Eg. by keeping vlc_input_attachment_Duplicate and vlc_input_attachment_Delete.

I don't see how an API/ABI break for libvlc plugins would be a problem for VLCKit as you can never have mixed versions of VLCKit in an app package. Further, the public API of VLCKit is unchanged, just the symbol list is which is considered private and shall not be used by third party apps.

As VLC-iOS is a first class user of the mainline VLCKit, I don't see how this could be patched privately there as we would want VLC-iOS to continue to use the normal VLCKit and not a fork.

@alexandre-janniaux let's merge this?

resolved all threads

merged

mentioned in merge request VLCMediaLibraryKit!25 (merged)