Add a modulemap file in the framework bundle for tvOS and iOS
The builds for tvOS and iOS distributed on cocoapods/carthage use the static version of the framework.
A framework bundle is created by the compileAndBuildVLCKit.sh
script but miss the Module map file. This PR addresses this by adding a Module map file to the generated framework bundle.
By the way I'm curious to know why you chose to create a static framework and to repack it in a framework bundle. It may be better to distribute the the dynamic versions since the Module map is generated automatically.
This address the issue that prevents swift dynamic framework to use VLCKit.
We can now use the import command to include VLCKit:
swift
import TVVLCKit
objective-c
@import TVVLCKit;
Merge request reports
Activity
assigned to @fkuehne
@jeremy.marchand We have a user mentioning in ticket #239 that you also need an Info.plist - is this accurate? Do we want to do that to fix this correctly?
Edited by Felix Paul Kühnechanged milestone to %3.2.1
@fkuehne I didn't encounter this issue. But I could check it and work on it this weekend.
@jeremy.marchand That would be great, thanks!
@fkuehne I don't think you need to but can't hurt to double check. otherwise lgtm
added 1 commit
- 0793d9b5 - Add a modulemap file in the framework bundle for tvOS and iOS
@fkuehne @mrvincenzo I didn't encounter any issue with the framework produced by the script despite having no plist. I have also tried the Carthage current binary and copied the module map in it, It works properly: It is actually what I'm doing in my demo app as a temporary hack for swift in https://github.com/kodlian/TVVLCPlayer.
I squashed my commits in one for merging.
mentioned in issue #191 (closed)
mentioned in issue #357 (closed)