Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
VLCKit
VLCKit
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 72
    • Issues 72
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 3
    • Merge Requests 3
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • VideoLAN
  • VLCKitVLCKit
  • Merge Requests
  • !71

Closed
Opened Oct 20, 2020 by Soomin Lee@bubuMaintainer
  • Report abuse
Report abuse

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch "https://code.videolan.org/bubu/VLCKit.git" "mediaplayer/stop-set/async/01"
git checkout -b "bubu/VLCKit-mediaplayer/stop-set/async/01" FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "3.0"
git merge --no-ff "bubu/VLCKit-mediaplayer/stop-set/async/01"

Step 4. Push the result of the merge to GitLab

git push origin "3.0"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Player: Rework dispatch_async usage

  • Overview 1
  • Commits 2
  • Pipelines 1
  • Changes 34

libvlc_media_player_set_media/stop are now asynchronous.

The usage of dispatch_async is not needed any more, except for the libvlc_media_player_release call.

Indeed, this function can be blocking since it can wait for the input closing.

Edited Oct 20, 2020 by Soomin Lee
Assignee
Assign to
3.3.16
Milestone
3.3.16
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: videolan/VLCKit!71
Source branch: mediaplayer/stop-set/async/01