Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • VLCKit VLCKit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare
  • Issues 114
    • Issues 114
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VideoLANVideoLAN
  • VLCKitVLCKit
  • Merge requests
  • !267

VLCMedia: refactors for simplifying the code

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alexandre Janniaux requested to merge alexandre-janniaux/VLCKit:media-refactor/1 into master Feb 14, 2023
  • Overview 4
  • Commits 7
  • Pipelines 3
  • Changes 3

Refactor in VLC 4.0 removed the libvlc_instance_t parameter to most functions from libvlc_media_t (in particular constructor) and only kept it for preparsing/thumbnailing requests.

This MR uses this beginning to remove some parameters, and then removes more code by simplifying even more the initializers.

A bigger impact change is the one adding the selector preparseWithOptions:timeout:library: allowing the user to provide its own VLCLibrary object to configure the preparsing options.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: media-refactor/1

VideoLAN code repository instance