[3.0]manage the time to live of the user_data instance of LibVLC Event Callback

manage the time to live of the user_data instance of LibVLC Event Callback.

This prevents access to the released instance in the LibVLC Event Callback and prevents unauthorized access to the released pointer.

The following rare crashes etc. will be fixed.

• libobjc.A.dylib objc_retain
• libobjc.A.dylib objc_msgSend
• libobjc.A.dylib objc_release

marked this merge request as draft

changed title from manage the time to live of the user_data instance of LibVLC Event Callback to Draft: [3.0]manage the time to live of the user_data instance of LibVLC Event Callback

changed the description

added 6 commits

• 5280b75b - Added VLCEventObjectManager class
• 5ec8f8f4 - VLCMedia: Use VLCEventObjectManager to manage the time to live of the...
• fb8142ee - VLCMediaList: Use VLCEventObjectManager to manage the time to live of the...
• 64a0c8ca - VLCMediaPlayer: Use VLCEventObjectManager to manage the time to live of the...
• 7bc3282a - VLCMediaListPlayer: Use VLCEventObjectManager to manage the time to live of...
• a57ce518 - VLCRendererDiscoverer: Use VLCEventObjectManager to manage the time to live of...

Compare with previous version

This is a complex but interesting solution. I'd like to have @umxprime's feedback on this before merge.

requested review from @umxprime

added 6 commits

• ddb1065e - Added VLCEventObjectManager class
• af0d360e - VLCMedia: Use VLCEventObjectManager to manage the time to live of the...
• 9606824e - VLCMediaList: Use VLCEventObjectManager to manage the time to live of the...
• 6bf734a6 - VLCMediaPlayer: Use VLCEventObjectManager to manage the time to live of the...
• 268a8108 - VLCMediaListPlayer: Use VLCEventObjectManager to manage the time to live of...
• 645b04b7 - VLCRendererDiscoverer: Use VLCEventObjectManager to manage the time to live of...

Compare with previous version

added 6 commits

• ac9a30f0 - Added VLCEventObjectManager class
• 6caa3790 - VLCMedia: Use VLCEventObjectManager to manage the time to live of the...
• b1e6e0d5 - VLCMediaList: Use VLCEventObjectManager to manage the time to live of the...
• aa57a77b - VLCMediaPlayer: Use VLCEventObjectManager to manage the time to live of the...
• 305fcb03 - VLCMediaListPlayer: Use VLCEventObjectManager to manage the time to live of...
• 79c5c81c - VLCRendererDiscoverer: Use VLCEventObjectManager to manage the time to live of...

Compare with previous version

added 6 commits

• 2861c56f - Added VLCEventObjectManager class
• fae392b7 - VLCMedia: Use VLCEventObjectManager to manage the time to live of the...
• 7e9c90bd - VLCMediaList: Use VLCEventObjectManager to manage the time to live of the...
• 559bc745 - VLCMediaListPlayer: Use VLCEventObjectManager to manage the time to live of...
• 21b42f9c - VLCMediaPlayer: Use VLCEventObjectManager to manage the time to live of the...
• 85eeece8 - VLCRendererDiscoverer: Use VLCEventObjectManager to manage the time to live of...

Compare with previous version

added 6 commits

• cfcfaef8 - Added VLCEventObjectManager class
• ea1bd4aa - VLCMedia: Use VLCEventObjectManager to manage the time to live of the...
• 7f0663ea - VLCMediaList: Use VLCEventObjectManager to manage the time to live of the...
• 7eabb0a0 - VLCMediaListPlayer: Use VLCEventObjectManager to manage the time to live of...
• 9a114835 - VLCMediaPlayer: Use VLCEventObjectManager to manage the time to live of the...
• 4d946a17 - VLCRendererDiscoverer: Use VLCEventObjectManager to manage the time to live of...

Compare with previous version

added 7 commits

• bea0f108 - 1 commit from branch videolan:3.0
• 6007d8c1 - Added VLCEventObjectManager class
• 7b8153da - VLCMedia: Use VLCEventObjectManager to manage the time to live of the...
• b46cc415 - VLCMediaList: Use VLCEventObjectManager to manage the time to live of the...
• 94014b83 - VLCMediaListPlayer: Use VLCEventObjectManager to manage the time to live of...
• d3405368 - VLCMediaPlayer: Use VLCEventObjectManager to manage the time to live of the...
• 467d7bb0 - VLCRendererDiscoverer: Use VLCEventObjectManager to manage the time to live of...

Compare with previous version

After a week of testing with 1000 active users per day, the crashes mentioned in this MR are gone.

But maybe I'm wrong in the first place.

Thank you for your review.

marked this merge request as ready

added 6 commits

• 30deac4e - Added VLCEventObjectManager class
• 1b94ef88 - VLCMedia: Use VLCEventObjectManager to manage the time to live of the...
• 45c7e6e6 - VLCMediaList: Use VLCEventObjectManager to manage the time to live of the...
• 573f4f3f - VLCMediaListPlayer: Use VLCEventObjectManager to manage the time to live of...
• e2ecfa2c - VLCMediaPlayer: Use VLCEventObjectManager to manage the time to live of the...
• ab46ea6c - VLCRendererDiscoverer: Use VLCEventObjectManager to manage the time to live of...

Compare with previous version

ping @umxprime

added 6 commits

• c169758b - Added VLCEventObjectManager class
• b46dfc36 - VLCMedia: Use VLCEventObjectManager to manage the time to live of the...
• 42658482 - VLCMediaList: Use VLCEventObjectManager to manage the time to live of the...
• 380d21d3 - VLCMediaListPlayer: Use VLCEventObjectManager to manage the time to live of...
• 266bc31a - VLCMediaPlayer: Use VLCEventObjectManager to manage the time to live of the...
• 39a36afa - VLCRendererDiscoverer: Use VLCEventObjectManager to manage the time to live of...

Compare with previous version

approved this merge request

merged

Thanks a lot for this complex contribution! I will forward port it to the v4 master branch!

changed milestone to %3.5.0