Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • VLCKit VLCKit
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare revisions
  • Issues 114
    • Issues 114
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VideoLANVideoLAN
  • VLCKitVLCKit
  • Merge requests
  • !106

Fix/libvlc symbolication

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Maxime Chapelet requested to merge umxprime/VLCKit:fix/libvlc-symbolication into 3.0 Nov 04, 2021
  • Overview 3
  • Commits 3
  • Pipelines 3
  • Changes 2

Libvlc debug symbols are missing and they are mandatory to analyse some stability issues happening actually on iOS. Two things were found causing this issue :

  1. Clang compiler didn't get the -g flag to generate libvlc symbols
  2. The libvlc static library target's settings were set to strip them when archive was invoked from the build script, even when Clang compiler generated them as expected

Actually I decided to put the -g flag in the EXTRA_CFLAGS variable in the build script to fix 1., and to change the xcodeproj target's build settings to fix 2.

Maybe 2. can be fixed without changing the target's build settings and by removing the SKIP_INSTALL=no override from the xcodebuild archive script's command, but I bet this setting override has its own purpose there. Any input about this will be appreciated.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/libvlc-symbolication

VideoLAN code repository instance