Skip to content
Snippets Groups Projects

Support for AvaloniaUI

Merged Shawn Black requested to merge shawnallen85/LibVLCSharp:avaloniaui into 3.x

I am working on a Linux app and started looking at using Avalonia UI for the UI platform.

Need the ability to render videos, so I started working on this.

Tested it on Linux (Ubuntu, haven't had a chance to try Fedora yet), Windows 10, MacOS 10.15.7.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Martin Finkel
  • Martin Finkel
  • Martin Finkel
  • Martin Finkel
    • Thank you for this! It seems really clean :-)

      The CI is complaining for some minor thing

       C:\hostedtoolcache\windows\dotnet\sdk\3.1.300\Sdks\NuGet.Build.Tasks.Pack\build\NuGet.Build.Tasks.Pack.targets(198,5): error NU5046: The icon file 'icon.png' does not exist in the package. [D:\a\1\s\src\LibVLCSharp.Avalonia\LibVLCSharp.Avalonia.csproj]

      I could not really test this though, as when I try to load the LibVLCSharp.Avalonia project into VS, it complains with

      LibVLCSharp\src\LibVLCSharp.Avalonia\LibVLCSharp.Avalonia.csproj : error  : The result "" of evaluating the value "$(AvaloniaBuildTasksLocation)" of the "AssemblyFile" attribute in element <UsingTask> is not valid.  C:\Users\Martin\.nuget\packages\avalonia\0.10.0-preview6\build\AvaloniaBuildTasks.targets

      Which VS version are you using? I'm on 16.7.3

    • Author Contributor

      Sorry, I didn't check when I had it open in my VM.

      I did an update a day or so back, so likely the latest and greatest.

      I was getting a ton of issues trying to Avalonia 0.10.0-preview6, so I kept it at preview5.

      Maybe you're getting something similar?

    • I'll try with preview5 and let you know.

    • Please register or sign in to reply
  • Martin Finkel
  • Shawn Black added 1 commit

    added 1 commit

    Compare with previous version

  • Shawn Black resolved all threads

    resolved all threads

    • Author Contributor

      I think everything is done based on the feedback.

      Let me know what you think.

      Happy Monday (well, I guess technically Tuesday, at least for me :P)

    • Happy Monday (well, I guess technically Tuesday, at least for me :P)

      I, too, live in the future :-)

      I think everything is done based on the feedback. Let me know what you think.

      Thanks, will have another look soon.

    • Please register or sign in to reply
  • Martin Finkel
  • Martin Finkel added 3 commits

    added 3 commits

    Compare with previous version

  • Martin Finkel added 2 commits

    added 2 commits

    Compare with previous version

  • I did some minor changes and kicked off a new CI build, let's see :-)

    https://github.com/videolan/libvlcsharp/pull/173

  • Martin Finkel added 1 commit

    added 1 commit

    Compare with previous version

  • Martin Finkel
  • This is really cool, as a feature.

  • Martin Finkel added 2 commits

    added 2 commits

    • fe286c14 - README: Add Avalonia
    • 3e95809c - CD: Update package count to include LibVLCSharp.Avalonia

    Compare with previous version

  • Martin Finkel added 1 commit

    added 1 commit

    Compare with previous version

  • Jérémy VIGNELLES approved this merge request

    approved this merge request

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading