Henrik Gramner authored 1 year ago and Henrik Gramner committed 1 year ago

Reduces memory usage by 6 kB per sb128 in 8bpc streams that
uses screen content tools when frame-threading is enabled.

Signed-off-by: James Almer <jamrial@gmail.com>

Signed-off-by: James Almer <jamrial@gmail.com>

Signed-off-by: James Almer <jamrial@gmail.com>

Signed-off-by: James Almer <jamrial@gmail.com>

Signed-off-by: James Almer <jamrial@gmail.com>

All of them are 32 bits values that shall be > 0

Signed-off-by: James Almer <jamrial@gmail.com>

Henrik Gramner authored 1 year ago and Henrik Gramner committed 1 year ago

The default __printf__ format attribute doesn't match what printf
functions actually support. Using __gnu_printf__ fixes it.

Completes the work started in cb5a095e.

Avoid wrapping external includes in extern "C" blocks. Also wrap all public headers in extern "C" blocks to allow them to be selectively included in C++ projects.

Fixes #422.

Nothing in the spec prevents a Temporal Unit from having more than one Metadata
OBU of type ITU-T T.35, so export them as an array instead of only exporting
the last one we parse.
This is backwards compatible with the previous implementation, as users unaware
of this change can ignore the n_itut_t35 field and still access the first (or
only) entry in the array as they have been doing until now.

James Almer authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Dav1dRef is an opaque struct to the API user, and they have no business
with these fields at all, so move them to the internal picture struct.

Signed-off-by: James Almer <jamrial@gmail.com>

James Almer authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Nothing in the spec prevents a Temporal Unit from having more than one Metadata
OBU of type ITU-T T.35, so export them as an array instead of only exporting
the last one we parse.
This is backwards compatible with the previous implementation, as users unaware
of this change can ignore the n_itut_t35 field and still access the first (or
only) entry in the array as they have been doing until now.

Signed-off-by: James Almer <jamrial@gmail.com>

Should be useful for scenarios like wanting only keyframes to quickly generate
a set of preview images of the whole stream.

This fixes building with MSVC (and older GCC versions) after
3e7886db.

'-fvisibility=hidden' only applies to definitions, not declarations,
so the compiler has to be conservative about how references to global
data symbols are performed.

Explicitly specifying the visibility allows for better code generation.

Henrik Gramner authored 2 years ago and Henrik Gramner committed 2 years ago

Increasing a reference counter only requires atomicity, but not
ordering or synchronization.

(To be used alongside --filmgrain.)

Addresses part of #310.

Signed-off-by: James Almer <jamrial@gmail.com>

Addresses part of #310.

Wan-Teh Chang authored 4 years ago and Ronald S. Bultje committed 3 years ago

Section 6.4.2 (Color config semantics) of the AV1 spec says:
  If matrix_coefficients is equal to MC_IDENTITY, it is a requirement of
  bitstream conformance that subsampling_x is equal to 0 and
  subsampling_y is equal to 0.
Add Dav1dSettings.strict_std_compliance flag which, when set, allows
aborting decoding when such standard-compliance violations fail, even
though they don't affect decoding. In CLI, this flag can be accessed
using -strict.

This change is motivated by a desire to be able to toggle between CPU
and GPU film gain synthesis in players such as VLC. Because VLC
initializes the codec before the vout (and, indeed, the active vout
module may change in the middle of decoding), it cannot make the
decision of whether to apply film grain in libdav1d as part of codec
initialization. It needs to be decided on a frame-by-frame basis
depending on whether the currently active vout supports film grain
synthesis or not.

Using the new API, users like VLC can simply set `apply_grain` to 0 and
then manually call `dav1d_apply_grain` whenever the vout does not
support GPU film grain synthesis. As a side note, `dav1d_apply_grain`
could also technically be called from dedicated worker threads,
something that libdav1d does not currently do internally.

The alternative to this solution would have been to allow changing
Dav1dSettings at runtime, but that would be more invasive and a proper
API would also need to take other settings into consideration, some of
which can't be changed as easily as `apply_grain`. This commit
represents a stop-gap solution.

Bump the minor version to allow clients to depend on this API.

Henrik Gramner authored 3 years ago and Henrik Gramner committed 3 years ago

Supports Linux, MacOS, and Windows.

Merges the 3 threading parameters into a single `--threads=` argument.
Frame threading can still be controlled via the `--framedelay=` argument.
Internally, the threading model is now a global thread/task pool design.

Co-authored-by: Ronald S. Bultje <rsbultje@gmail.com>

Christophe Gisquet authored 3 years ago and Henrik Gramner committed 3 years ago

Reduces size from 16B to 12B, while maintaining a 4-byte alignment.

James Almer authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Helps differentiating actual errors in the buffer data or passed-in arguments
with scenarios like empty buffers or containing OBUs other than Sequence
Header.

Henrik Gramner authored 3 years ago and Henrik Gramner committed 3 years ago

We use the 'noinline' attribute in order to reduce code size, but that
doesn't prevent gcc from cloning the function, which is something that
goes against the purpose of preventing inlining in the first place.

Adding the 'noclone' attribute reduces the (stripped) binary size by
around 45 kB on x86-64.