Skip to content
Snippets Groups Projects
  1. Feb 03, 2023
  2. Feb 02, 2023
    • Alexandre Janniaux's avatar
      test: image: check that encoder opened · 46ca013b
      Alexandre Janniaux authored and Felix Paul Kühne's avatar Felix Paul Kühne committed
      The test can pass if a different encoder is used during the test, but we
      need to ensure it's really the encoder from the test.
      
      This was catched when changing the capability from video encoder into
      image encoder, which led the test to use the png encoder instead.
      46ca013b
    • Alexandre Janniaux's avatar
      image: merge if() condition and assert · 66f60e1a
      Alexandre Janniaux authored and Felix Paul Kühne's avatar Felix Paul Kühne committed
      The if block is only used to trigger the assert now, so merge it into
      the assert itself.
      66f60e1a
    • Alexandre Janniaux's avatar
      image: ensure picture is released from client · 49a1f114
      Alexandre Janniaux authored and Felix Paul Kühne's avatar Felix Paul Kühne committed
      Ensure the client calling the export to block_t is also responsible for
      releasing the picture it exports.
      
      Previous commits were adding the release to match behaviour of the
      converter before refactoring everything, but it was a mistake and led to
      issues with other parts of the pipeline, in particular the transcoder,
      and some clients were more adapted to the converter path + hold of
      original rather than the non-conversion path, which would then have been
      simpler to do from the start.
      
      This MR adds the necessary hold and release to remove those from the
      encoders and the clients, and is tested against the unmerged
      libvlc/media.c test for thumbnailing too.
      
      Revert "png: fix picture release on encoder"
      This reverts commit d4c93a29.
      
      Revert "jpeg: fix picture release on encoder"
      This reverts commit cccc085e.
      
      Revert "avcodec: encoder: fix picture release"
      This reverts commit 5a145f34.
      
      Revert "codec: vpx: fix picture release on encoder"
      This reverts commit 5dde7db3.
      
      Revert "image: fix picture leak in case of error"
      This reverts commit 1bf09fe8.
      
      Revert "misc: thumbnailer: release picture when interrupted"
      This reverts commit 004b9900.
      49a1f114
    • Zhao Zhili's avatar
      interop_vaapi: sync before ExportSurfaceHandle · 28bf3ccc
      Zhao Zhili authored and Felix Paul Kühne's avatar Felix Paul Kühne committed
      ExportSurfaceHandle does not perform any synchronisation. If the
      contents of the surface will be read, vaSyncSurface() must be
      called before doing so.
      28bf3ccc
    • Zhao Zhili's avatar
      interop_vaapi: set ExportSurfaceHandle flags · 1264e7b9
      Zhao Zhili authored and Felix Paul Kühne's avatar Felix Paul Kühne committed
      Set VA_EXPORT_SURFACE_READ_ONLY flag, and request separate layers
      via VA_EXPORT_SURFACE_SEPARATE_LAYERS explicitly.
      1264e7b9
    • Prince Gupta's avatar
      qt: reset pin-controls on settings dialog cancel · f791cbed
      Prince Gupta authored and Steve Lhomme's avatar Steve Lhomme committed
      fixes #27773
      f791cbed
    • Steve Lhomme's avatar
      meson: add a TODO for qmlgencache support · 8866e7c7
      Steve Lhomme authored
      Not sure how to handle it.
      8866e7c7
Loading