Skip to content
  • Filip Roséen's avatar
    demux/adaptive: DOMParser: retain root element if empty · 9ac321c6
    Filip Roséen authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
    
    
    An XML file containing a single root element without children would,
    given the previous implementation, have its only element ignored.
    Resulting in a memory-leak of the node in question, while also (more
    importantly) making it impossible to access the associated data.
    
    As XML does not allow documents such as the below (only a single root
    is allowed):
    
       <?xml version="1.0">
       <ill-formed />
       <ill-formed></ill-formed>
    
    Simply checking to see so that we are not popping away all our tags
    are sufficient in order to fix this bug. The changes also make sure
    that we do not invoke std::stack<...>::pop on an empty container
    (which is undefined-behavior).
    
    fixes: #18122
    
    Signed-off-by: default avatarJean-Baptiste Kempf <jb@videolan.org>
    9ac321c6