The core uses IsSubpicInVideo() to determine if the subpicture should be rendered
inside the video. In most cases the subpictures with the b_subtitle flag (start and stop times)
signal a subtitle SPU. But for libass it's not supposed to be rendered outside
of the video. It has to match the video location.

IsSubpicInVideo() can't tell if the regions are absolute (positioned inside the video)
unless there's an actual region. So we create a dummy one with the b_absolute flag.

Alexandre Janniaux authored 2 months ago and Steve Lhomme committed 2 months ago

Otherwise, building on windows can fail with:

    modules/meson.build:407:17: ERROR: File file_crypt_win32.c does not exist.

Test C23 header, clang/gcc builtins and compat versions.

So the compiler can check the callers.

Rather than a local string.

Without varargs which is most of the call we use.
And it won't parse and allocate a new string each time.

MP4_BoxGet_Path must always be called with a usable path that won't
be free'd by MP4_BoxGet_Path().

The format string doesn't contain any string to replace.

It requires loading nvEncodeAPI[64].dll from the system which is not possible in UWP.

Brad Smith authored 2 months ago and Steve Lhomme committed 2 months ago

OpenBSD and NetBSD do not have qsort_r().

Alexandre Janniaux authored 3 months ago and Steve Lhomme committed 2 months ago

This allows checking that the dependency could be found, in particular
to set the enabled: flags for plugins, without first checking whether
the condition to do the lookup are met.

Alexandre Janniaux authored 2 months ago and Steve Lhomme committed 2 months ago

The split from 91eaf42c was missing the
static qualifier for the functions, leading to warnings.

*pi_preroll is a vlc_tick_t that can never be bigger than VLC_TICK_MAX.

Alexandre Janniaux authored 2 months ago and Steve Lhomme committed 2 months ago

This actually disable the tests when a module the test depends on is
being disabled, and display a warning listing the modules that were
missing for the test.

Alexandre Janniaux authored 2 months ago and Steve Lhomme committed 2 months ago

The module manifest is indexed by the name and allows checking whether a
given module has been declared or not. In particular, it's used by the
tests to check whether the module was enabled or not. For this feature
to work, it should always be stored and not just when the module is
actually enabled.

Alexandre Janniaux authored 2 months ago and Steve Lhomme committed 2 months ago

Without commit "input: es_out: fix non-matching main_clock bus", the
test is failing with the following assertion:

    core debug: The input can't pace, selecting the input (PCR) as the clock source
    Assertion failed: (vlc_mutex_held(&main_clock->lock)), function vlc_clock_main_CreateInputMaster, file clock.c, line 998.
    FAIL test_input_es_out (exit status: 134)

Co-authored-by: Sergio Ammirata <sergio@ammirata.net>

Reported that some US feeds with mpegts were triggering the assertion on
vlc_clock_main_CreateInputMaster() call.

Alexandre Janniaux authored 2 months ago and Steve Lhomme committed 2 months ago

Fix the following assertion in some cases multiple programs are used by
the es_out, leading to a mismatch between the main_clock bus being locked
and the main_clock bus creating the input vlc_clock.

    Assertion failed: (vlc_mutex_held(&main_clock->lock)), function vlc_clock_main_CreateInputMaster, file clock.c, line 998.
    FAIL test_input_es_out (exit status: 134)

Co-authored-by: Sergio Ammirata <sergio@ammirata.net>

Reported that some US feeds with mpegts were triggering the assertion on
vlc_clock_main_CreateInputMaster() call.

Thomas Guillem authored 2 months ago and Felix Paul Kühne committed 2 months ago

The gc might not release the SurfaceTexture from its destructor.

Fatih Uzunoğlu authored 2 months ago and Felix Paul Kühne committed 2 months ago

This fixes closing the window using the CSD close button crashing the application.

It should not be necessary to delete the window because it has a parent window and
the parent window already gets deleted.

Fatih Uzunoğlu authored 2 months ago and Felix Paul Kühne committed 2 months ago

Currently, if Qt's event loop is not fast enough to consume the high resolution events,
the events may backlog.