By default we use the dynamic runtime and need to ship libc++_shared.so.

This is also needed in libvlcjni because ndk-build copies the libc++_shared.so
depending on the value of APP_STL. So even if it's not copied for libvlc.so
it would always be copied with libvlcjni.so.

Partially reverts e45d311d.

The libvlcjni Java code still loads the c++_shared library unconditionally.
We could use ReLink and let the loader do its job [^1].
Apparently that's what happens since API 23.

[^1]: https://github.com/KeepSafe/ReLinker

The -lc++ of pkg-config file ends up being used even when forcing APP_STL to
c++_static.

It's not compiling any C++ code.

It's only used if any of the sources to compile are C++.
This is not the case as we only build libvlcjni-modules.c and libvlcjni-symbols.c.

It links properly because some pkg-config files are forcing -lc++ when linking.

We can give a hint to ndk-build that the code contains C++ code.

We may want to have a different ANDROID_API version regardless of the NDK (as long as it supports it).

This will turn on 16k aligned pages by default.

As in vlc-android@d5e23571

And reorder to match vlc-android.

No code changes is needed between the two.
The 16k page alignement is by default in NDK 28 but we can still set the flags.

By passing "-z max-page-size=16384" to the linker.

Newer Android devices use 16KB and require a recompilation with this flag.
See https://developer.android.com/guide/practices/page-sizes

Neither VLC nor the contribs (used by Android) use PAGE_SIZE directly so it
should be fine.

This flag is needed regardless the use of the NDK 27 or not.

The CFLAGS/CXXFLAGS is probably not needed by added just in case.

This will require an update on the VLC side.

Duncan McNamara authored 4 months ago and Thomas Guillem committed 4 months ago

Add ParseForced to the parse flags in IMedia after some changes in
vlc with commit vlc@41323953

Steve Lhomme authored 8 months ago and Thomas Guillem committed 5 months ago

Just like all other API's that were introduced in 4.0.

Steve Lhomme authored 8 months ago and Thomas Guillem committed 5 months ago

To match the official libvlc 4 API.

It's only used to build libvlcjni.so

So we can move the script to build libvlc.so in VLC.

We don't pass anymore VLC_BUILD_JNI to the NDK builder.
One .mk is for libvlc only, the other is for the JNI part only.

ef560af5 broke b6b33ffb

Steve Lhomme authored 10 months ago and Duncan McNamara committed 9 months ago

The minimum Android version is 21 (Lollipop) on VLC 4.0.
The test is always false.

Steve Lhomme authored 10 months ago and Duncan McNamara committed 9 months ago

The configure script can figure out the proper path(es) needed when using contribs.

Steve Lhomme authored 10 months ago and Duncan McNamara committed 9 months ago

If the configure script needs to find a native tool that may be in there,
it will find it.