They are not needed and waste space.

We keep the known sizes in case we know what's inside someday.

Just like pci_t, dsi_t and its sub structures is read bit by bit, so we don't
need the packing in memory. This could make the compiled code slightly more
optimized.

They depends on the packing of btni_t. Since btni_t is no longer packed, they
cannot be packed anymore.

This is not a problem as they are read bit by bit in navRead_PCI().

The use of bitfields of 10 bits makes the use of `unsigned char` impossible.
That means the compiler might use more bits than expected for the 4*12 bits.
This is the case with MS-compatible compilers. We cannot guarantee that the
btin_t will use the same 10 octets as used in the binary blob.

In the end btin_t is not read as a packed structure but bit by bit in
navRead_PCI().

Close #8

This was authorized by Eric Smith, original author of VOBDUMP, by email
on May 15, 2022

Steve Lhomme authored 3 years ago and Jean-Baptiste Kempf committed 2 years ago

According to [1] these 16 bits represent the "end address relative to command table".
This corresponds to the last_byte check in other places.

[1] http://dvd.sourceforge.net/dvdinfo/pgc.html#cmd

Steve Lhomme authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

It may not be in the end of the buffer anymore.

The byte value used was always equivalent to
> state->start[state->byte_position] << state->bit_position

Also constify the read buffer.

Steve Lhomme authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

The comments say it exists in the wild.

calloc() may or may not return NULL in that case. Just use NULL but assume it's
not an error.

to compute a canonical path

Steve Lhomme authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

We were allocating 4x the number of PTTs. We should use the same value as
nr_of_ptts.

It is not checked to be zero as most other field so may contain useful values.

Brad Smith authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

a.out support was obsolete 18 years ago.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Brad Smith authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Mathias Couder authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

And notably add VideoLAN Code of Conduct and improve lisibility

This issues a warning for each packed struct each time the header gets
included

Actually a work-around, tbh, but it'll take more time to fix.