- Dec 21, 2015
-
-
James M Snell authored
Maintenance Update Notable changes * Roughly 78% of the commits are documentation and test improvements * domains: - Fix handling of uncaught exceptions (Julien Gilli) [#3884](https://github.com/nodejs/node/pull/3884) * deps: - Upgrade to npm 2.14.12 (Kat Marchán) [#4110](https://github.com/nodejs/node/pull/4110) - Backport 819b40a from V8 upstream (Michaël Zasso) [#3938](https://github.com/nodejs/node/pull/3938) - Updated node LICENSE file with new npm license (Kat Marchán) [#4110](https://github.com/nodejs/node/pull/4110)
-
Kat Marchán authored
PR-URL: https://github.com/nodejs/node/pull/4110 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
-
- Dec 17, 2015
-
-
Julien Gilli authored
Fix node exiting due to an exception being thrown rather than emitting an `'uncaughtException'` event on the process object when: 1. no error handler is set on the domain within which an error is thrown 2. an `'uncaughtException'` event listener is set on the process Also fix an issue where the process would not abort in the proper function call if an error is thrown within a domain with no error handler and `--abort-on-uncaught-exception` is used. Fixes #3607 and #3653. PR: #3884 PR-URL: https://github.com/nodejs/node/pull/3884 Reviewed-By: James M Snell <jasnell@gmail.com>
-
Myles Borins authored
The CoC requests to avoid the casual use of profanity. PR-URL: https://github.com/nodejs/node/pull/4122 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
-
Scott Buchanan authored
trivial commit to fix a couple inconsistent references to the name of the project PR-URL: https://github.com/nodejs/node/pull/4136 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
-
Luigi Pinca authored
PR-URL: https://github.com/nodejs/node/pull/4089 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
-
Jan Krems authored
PR-URL: https://github.com/nodejs/node/pull/4075 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
-
Rich Trott authored
test-http-exit-delay was introduced to confirm the removal of a 1 second delay that can occur when exiting node after an http request. This change refactors the test for simplicity and also in the hopes of either eliminating flakiness on CI or, if not that, at least making the source of the flakiness easier to track down. Ref: https://github.com/nodejs/node/commit/16b59cbc Fixes: https://github.com/nodejs/node/issues/4045 PR-URL: https://github.com/nodejs/node/pull/4055 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
-
Fedor Indutny authored
If `.setEncoding` was called on input stream - all emitted `data` will be `String`s instances, not `Buffer`s. This is unacceptable for `StreamWrap`, and should not lead to the crash. Fix: https://github.com/nodejs/node/issues/3970 PR-URL: https://github.com/nodejs/node/pull/4031 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
-
Fedor Indutny authored
`v8_use_snapshot` should be either `true` or `false`, not 1 or 0. PR-URL: https://github.com/nodejs/node/pull/3962 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/4011 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
-
Santiago Gimeno authored
Sometimes the test was timing out because the worker process remained stuck in the breakpoint and didn't exit. This could happen because the continue was sent before the breakpoint was set. If that's the case, with this change, a new continue command is sent so the worker process can end. PR-URL: https://github.com/nodejs/node/pull/4009 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
-
Peter A. Bigot authored
The algorithm used to convert negative values to hex generates incorrect values when the low byte(s) of the value are zero because a carried subtraction is applied prematurely. Fixes: https://github.com/nodejs/node/issues/3992 PR-URL: https://github.com/nodejs/node/pull/3994 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Signed-off-by: Peter A. Bigot <pab@pabigot.com>
-
Santiago Gimeno authored
As it can happen that the HTTP response is received in more than one TCP chunk. PR-URL: https://github.com/nodejs/node/pull/3961 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
-
Santiago Gimeno authored
Check if the worker 'isDead' instead of 'isConnected' as the 'disconnect' event is not guaranteed to be received before the 'exit' event. Remove the 'net' dependency as it is not used. PR-URL: https://github.com/nodejs/node/pull/3954 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
-
James M Snell authored
Charter for the HTTP Working Group PR-URL: https://github.com/nodejs/node/pull/3919 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
-
Michael Dawson authored
Add Benchmarking and Post-Mortem workgroups as they were missing. Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <ben@strongloop.com> PR-URL: https://github.com/nodejs/node/pull/3450
-
Bryan English authored
It also tests displayPrompt by checking for '> '. PR-URL: https://github.com/nodejs/node/pull/3908 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Yazhong Liu authored
A value shouldn't be described as doing inherit from some class, more strictly, the value is an instance of the class `Error`. PR-URL: https://github.com/nodejs/node/pull/3658 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Stephan Belanger <admin@stephenbelanger.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
-
João Reis authored
Before this change, configure used processor specific macro defines (like __ARM_ARCH_6M__) to detect the arm processor version. This changes configure to use __ARM_ARCH, that should be defined to the correct version. Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: https://github.com/nodejs/node/pull/4123
-
João Reis authored
When cross compiling, GYP uses the variables CC_host and CXX_host to find the host compiler, if they are defined. This ensures that variable is used, if defined, when detecting the host architecture. Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/4117
-
Rod Vagg authored
* Include reference to CVE-2015-8027 * Fix "socket may no longer have a socket" reference * Expand on non-existent parser causing the error * Soften language for CVE-2015-3193 as impact may not be as great as expected * Clarify that CVE-2015-3194 affects TLS servers using _client certificate authentication_ * Include reference to CVE-2015-6764 * Remove links to nodejs/node-private in commits list PR-URL: https://github.com/nodejs/node/pull/4155 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
-
Kat Marchán authored
PR-URL: https://github.com/nodejs/node/pull/4110 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
-
Rich Trott authored
Mark test-net-socket-local-address flaky on FreeBSD. It times out with some frequency on CI. Ref: https://github.com/nodejs/node/issues/2475 PR-URL: https://github.com/nodejs/node/pull/4016 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
-
Rich Trott authored
See https://github.com/nodejs/node/issues/3957 for details and examples failures. Ref: https://github.com/nodejs/node/issues/3957 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: https://github.com/nodejs/node/pull/4006
-
Rich Trott authored
This test was marked flaky after failing in CI on arm7-wheezy two months ago. It has not failed there since. This commit removes the flaky designation. Fixes: https://github.com/nodejs/node/issues/2554 PR-URL: https://github.com/nodejs/node/pull/3620 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Jonathan Persson authored
Links nested in backticks were not visually distinguishable before, this fixes them. PR-URL: https://github.com/nodejs/node/pull/4068 Reviewed-By: Roman Reiss <me@silverwind.io>
-
Rich Trott authored
See https://github.com/nodejs/node/issues/3635 for details and failure examples. Ref: https://github.com/nodejs/node/issues/3635 PR-URL: https://github.com/nodejs/node/pull/4005 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/4000 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
-
Bryan English authored
The old version of the text here was slightly incorrect, so it just defers the details to the section in which they're fully described. PR-URL: https://github.com/nodejs/node/pull/3997 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
-
Rich Trott authored
Test test-net-socket-local-address is flaky in FreeBSD jail but robust otherwise. Fixes: https://github.com/nodejs/node/issues/2475 PR-URL: https://github.com/nodejs/node/pull/3995 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
-
Julien Gilli authored
test-domain-exit-dispose-again had been written for node v0.10.x, and was using the fact that callbacks scheduled with `process.nextTick` wouldn't run if the domain attached to it was disposed. This is not longer the case, and as a result the test would not catch any regression: it would always pass. This change rewrites that test to check that the current domain is cleared properly when processing the rest of the timers list if a timer's callback throws an error. This makes the test fail without the original fix, and pass with the original fix, as expected. PR: #3990 PR-URL: https://github.com/nodejs/node/pull/3990 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
-
Lewis Cowper authored
Removing ableist language because we don't need to make the comparison to people with mental health issues to get our point across. PR-URL: https://github.com/nodejs/node/pull/3980 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
-
Rich Trott authored
The test did not fail after 9999 runs in continuous integration. Remove it's flaky status. Fixes: https://github.com/nodejs/node/issues/2557 PR-URL: https://github.com/nodejs/node/pull/3975 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
-
Rich Trott authored
Use common.platformTimeout() to make test more reliable on Raspberry Pi. Fixes: https://github.com/nodejs/node/issues/2555 PR-URL: https://github.com/nodejs/node/pull/3968 Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
-
Roman Reiss authored
By using the same unit for the offset of the main column as used for the left column width, we ensure that browsers render the columns conistently. Ref: https://github.com/nodejs/help/issues/32 PR-URL: https://github.com/nodejs/node/pull/3948 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Jan Schär authored
Adds localAddress and localPort to req so we have better error messages. Also fixes a case where ex is used before it is declared. PR-URL: https://github.com/nodejs/node/pull/3946 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
-
Alexander Gromnitsky authored
PR-URL: https://github.com/nodejs/node/pull/3944 Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Myles Borins <mborins@us.ibm.com>
-
Rich Trott authored
SmartOS has a bug that causes unexpected ECONNREFUSED errors. See https://smartos.org/bugview/OS-2767 If ECONNREFUSED on SmartOS, retry the test one time. Fixes: https://github.com/nodejs/node/issues/3864 Fixes: https://github.com/nodejs/node/issues/2815 PR-URL: https://github.com/nodejs/node/pull/3941 Reviewed-By: Fedor Indutny <fedor@indutny.com>
-
Colin Ihrig authored
This commit refers readers to util.inspect() for an explanation of buffer.inspect(). Fixes: https://github.com/nodejs/node/issues/3918 PR-URL: https://github.com/nodejs/node/pull/3921 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
-