Skip to content
Snippets Groups Projects

qml: properly align item if secondary label is missing, and hide the "vlc://nop" for node/directory items

Closed Leon Vitanos requested to merge vlc-nop into master
All threads resolved!

fix: #26354 and #26353

Edited by Leon Vitanos

Merge request reports

Merge request pipeline #235280 passed

Merge request pipeline passed for b7fe7d66

Approval is optional

Closed by Leon VitanosLeon Vitanos 2 years ago (Jun 26, 2022 11:57am UTC)

Merge details

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • nit: regarding commit messages they should rather be written like this, the ticket number should not be in the first line, and it's usually prefixed by the "module" for us that's either qt: or qml:

    qml: properly align item if secondary label is missing
    
    fix: #26353
    qml: hide the "vlc://nop" for node/directory items
    
    fix: #26354 
  • Leon Vitanos added 1 commit

    added 1 commit

    • ce8265b3 - hide the "vlc://nop" for node/directory items

    Compare with previous version

  • Leon Vitanos added 1 commit

    added 1 commit

    • b8c6f339 - qml: properly align item if secondary label is missing

    Compare with previous version

  • Leon Vitanos added 1 commit

    added 1 commit

    • 4da81aa9 - qml: hide the "vlc://nop" for node/directory items

    Compare with previous version

  • Leon Vitanos changed title from fix: #26353 and #26354: properly align item if secondary label is missing, and hide the "vlc://nop" for node/directory items to qml: properly align item if secondary label is missing, and hide the "vlc://nop" for node/directory items

    changed title from fix: #26353 and #26354: properly align item if secondary label is missing, and hide the "vlc://nop" for node/directory items to qml: properly align item if secondary label is missing, and hide the "vlc://nop" for node/directory items

  • Leon Vitanos changed the description

    changed the description

  • Leon Vitanos resolved all threads

    resolved all threads

  • Felix Paul Kühne added 344 commits

    added 344 commits

    • 4da81aa9...248631ae - 314 commits from branch master
    • 3c5459fb - demux: ts: extract multiplexed metadata access units
    • 5c1a2955 - Set channel top space constraint to 10
    • 60ae5bd4 - Set frame rate top space constraint to 10
    • 2e08074d - Set enable video bottom space constraint to 9
    • 702b1eeb - messages: remove always NULL parameter
    • be790d9d - vlc_messages: fix documentation referencing vlc_msg_SetCallback()
    • ff415efe - access: remove hardcoded size
    • 9dfc146b - contrib: vulkan-loader: fix build with cmake generator other than make
    • 1cd6abdf - avcodec: remove useless flush
    • c3c2d535 - vlc_stream: fix the vlc_stream_ReadPartial() documentation
    • afcbf621 - qml: expose *margin properties in KeyNavigableTableView
    • 7f8dfda3 - qml: fix keyboard focus in video view
    • 0391b33a - qml: remove extra top padding from video list main view
    • 1ea09518 - qml: don't lose selection on context button in table view
    • 001498aa - qml: simplify selection condition
    • 94281684 - bootstrap: use ${MAKE} as appropriate
    • 5c35cf0d - contrib/nvcodec: use $(MAKE) as appropriate
    • 82886b45 - contrib/ncurses: use $(MAKE) as appropriate
    • b39ffc48 - dvbsub: update note
    • 43c69bf2 - dvbsub: clarify a note
    • 56a6ef98 - macosx: Only set VLCImageView images when necessary
    • 2c872aed - macosx: Bring toolbar design closer to mockups
    • 5208df51 - qml: fix maximize button state check
    • 5ebdaa84 - qt: pass and act on the main widget in InterfaceWindowHandler when available
    • 22590583 - wasapi: fix no audio output due to invalid i_physical_channels
    • 54480f14 - qml: Create EmptyLabelButton
    • 11e72d64 - qml: Create EmptyLabelHint
    • 47b03903 - qml/PlaylistMediaList: Update to EmpyLabelHint
    • 53306589 - qml: properly align item if secondary label is missing
    • b7fe7d66 - qml: hide the "vlc://nop" for node/directory items

    Compare with previous version

  • closed

  • Please register or sign in to reply
    Loading