Should improve readability.

This should improve maintainability and readability.
No functional changes.

Janne Grunau authored 5 years ago and Janne Grunau committed 5 years ago

The fuzzing binaries will require the same meson version, see dav1d!919.

Prevent timeouts such as this one in CI:

553/878 dav1d:testdata-8 / autostitch-480p-240p-160p  TIMEOUT 30.02 s

See dav1d#297.

Reported in dav1d#295

See dav1d#294.

Janne Grunau authored 5 years ago and Jean-Baptiste Kempf committed 5 years ago

Use the wrapping capabilities of meson test.
`meson test --wrap ../tests/dav1d-test-data/wrap_mt.sh` will append
the values of the environment variables FRAMETHREADS and TILETHREADS
as '--framethreads' and '--tilethreads' command line parameters.
If the varables are not set it will default to 2 frame and tile threads.

Reported in dav1d#288

 ../../src/dav1d/src/recon_tmpl.c:786:54: runtime error: signed integer overflow: 65524 * 65348 cannot be represented in type 'int'
    #0 0x58cd72 in warp_affine /src/dav1d/src/recon_tmpl.c:786:54
    #1 0x5877c1 in dav1d_recon_b_inter_16bpc /src/dav1d/src/recon_tmpl.c:1271:19
    #2 0x4e24f4 in decode_b /src/dav1d/src/decode.c:1859:17
    #3 0x4d20b8 in decode_sb /src/dav1d/src/decode.c:2248:17
    #4 0x4d136d in dav1d_decode_tile_sbrow /src/dav1d/src/decode.c:2557:13
    #5 0x4cd2f7 in dav1d_tile_task /src/dav1d/src/thread_task.c:95:29
    #6 0x7ff0337736b9 in start_thread
    #7 0x7ff032b7e41c in clone /build/glibc-LK5gWL/glibc-2.23/sysdeps/unix/sysv/linux/x86_64/clone.S:109

AddressSanitizer:DEADLYSIGNAL
=================================================================
==18085==ERROR: AddressSanitizer: ABRT on unknown address 0xd7e9000046a5 (pc 0x7f4fbbfac602 bp 0x7f4fb5df1ec0 sp 0x7f4fb5df1d98 T2)
    @     0x7f4fbbf9722d  clone
AddressSanitizer:DEADLYSIGNAL
    #0 0x7f4fbbfac601 in __GI_raise (/usr/grte/v4/lib64/libc.so.6+0x4c601)
    #1 0x55758890d6b3 in base_logging::LogMessage::FailWithoutStackTrace() base/logging.cc:1246:3
    #2 0x557588912c1f in base_logging::LogMessage::SendToLog() base/logging.cc:1129:7
    #3 0x557588913a43 in base_logging::LogMessage::Flush() base/logging.cc:902:3
    #4 0x55758890d6f8 in base_logging::LogMessageFatal::~LogMessageFatal() base/logging.cc:1484:3
    #5 0x55758890db27 in __assert_fail base/logging.cc:84:3
    #6 0x55758871e405 in dav1d_prepare_intra_edges_16bpc third_party/dav1d/src/ipred_prepare_tmpl.c:89:5
    #7 0x55758876bcb8 in dav1d_recon_b_intra_16bpc third_party/dav1d/src/recon_tmpl.c:829:25
    #8 0x5575886a642b in decode_b third_party/dav1d/src/decode.c:1175:13
    #9 0x55758868eb85 in decode_sb third_party/dav1d/src/decode.c:2040:17
    #10 0x55758868d188 in dav1d_decode_tile_sbrow third_party/dav1d/src/decode.c:2542:13
    #11 0x5575887106f2 in dav1d_tile_task third_party/dav1d/src/thread_task.c:128:25
    #12 0x7f4fbc1224e7 in start_thread (/usr/grte/v4/lib64/libpthread.so.0+0x74e7)

This testcase was generated with a modified aomenc to insert sequence
headers before every frame and writing random data into the
encoder_buffer_delay bitsream field. See dav1d!593

Add testcase for #248.

A new sequence starts in the middle of these, unlike samples where the
frame_size_override_flag field is used to signal size changes in a per
frame basis.
The samples were remuxed into ivf from the original Mastroska container
in the libaom suite so they may be decodable with the dav1d CLI.

Tested to be bitexact with the output of aomdec.

==1==ERROR: AddressSanitizer: memcpy-param-overlap: memory ranges [0x7fcdfe228a00,0x7fcdfe228b00) and [0x7fcdfe228902, 0x7fcdfe228a02) overlap
SCARINESS: 10 (memcpy-param-overlap)
    #0 0x4e99c9 in __asan_memcpy _asan_rtl_
    #1 0x60d4a4 in put_c /src/dav1d/src/mc_tmpl.c:52:9
    #2 0x6075ae in put_bilin_c /src/dav1d/src/mc_tmpl.c:433:9
    #3 0x62f33f in mc /src/dav1d/src/recon_tmpl.c:546:13
    #4 0x626789 in dav1d_recon_b_inter_16bpc /src/dav1d/src/recon_tmpl.c:1170:15
    #5 0x55fa2d in decode_b /src/dav1d/src/decode.c:1322:17
    #6 0x543d8a in decode_sb /src/dav1d/src/decode.c:1957:17
    #7 0x542a68 in dav1d_decode_tile_sbrow /src/dav1d/src/decode.c:2469:13
    #8 0x533455 in dav1d_tile_task /src/dav1d/src/thread_task.c:92:29
    #9 0x7fce056266b9 in start_thread
    #10 0x7fce04a3141c in clone /build/glibc-Cl5G7W/glibc-2.23/sysdeps/unix/sysv/linux/x86_64/clone.S:109
0x7fcdfe228a00 is located 512 bytes inside of 442368-byte region [0x7fcdfe228800,0x7fcdfe294800)
allocated by thread T0 here:
    #0 0x4ec168 in __interceptor_posix_memalign _asan_rtl_
    #1 0x52c5b1 in dav1d_alloc_aligned /src/dav1d/include/common/mem.h:46:9
    #2 0x52c324 in default_picture_allocator /src/dav1d/src/picture.c:60:21
    #3 0x52c057 in fuzz_picture_allocator /src/dav1d/tests/libfuzzer/dav1d_fuzzer.c:66:12
    #4 0x52caae in picture_alloc_with_edges /src/dav1d/src/picture.c:125:15
    #5 0x52c7b4 in dav1d_thread_picture_alloc /src/dav1d/src/picture.c:156:9
    #6 0x54f4b3 in dav1d_submit_frame /src/dav1d/src/decode.c:3125:11
    #7 0x53427b in dav1d_parse_obus /src/dav1d/src/obu.c:1412:24
    #8 0x531926 in dav1d_get_picture /src/dav1d/src/lib.c:347:15
    #9 0x52bc70 in LLVMFuzzerTestOneInput /src/dav1d/tests/libfuzzer/dav1d_fuzzer.c:156:19
    #10 0x64b15a in ExecuteFilesOnyByOne(int, char**) /src/libfuzzer/afl/afl_driver.cpp:301:5
    #11 0x64b6be in main /src/libfuzzer/afl/afl_driver.cpp:339:12
    #12 0x7fce0494a82f in __libc_start_main /build/glibc-Cl5G7W/glibc-2.23/csu/libc-start.c:291
Thread T2 created by T0 here:
    #0 0x43694d in __interceptor_pthread_create _asan_rtl_
    #1 0x52f337 in dav1d_open /src/dav1d/src/lib.c:137:17
    #2 0x52baee in LLVMFuzzerTestOneInput /src/dav1d/tests/libfuzzer/dav1d_fuzzer.c:118:11
    #3 0x64b15a in ExecuteFilesOnyByOne(int, char**) /src/libfuzzer/afl/afl_driver.cpp:301:5
    #4 0x64b6be in main /src/libfuzzer/afl/afl_driver.cpp:339:12
    #5 0x7fce0494a82f in __libc_start_main /build/glibc-Cl5G7W/glibc-2.23/csu/libc-start.c:291
0x7fcdfe228902 is located 258 bytes inside of 442368-byte region [0x7fcdfe228800,0x7fcdfe294800)
allocated by thread T0 here:
    #0 0x4ec168 in __interceptor_posix_memalign _asan_rtl_
    #1 0x52c5b1 in dav1d_alloc_aligned /src/dav1d/include/common/mem.h:46:9
    #2 0x52c324 in default_picture_allocator /src/dav1d/src/picture.c:60:21
    #3 0x52c057 in fuzz_picture_allocator /src/dav1d/tests/libfuzzer/dav1d_fuzzer.c:66:12
    #4 0x52caae in picture_alloc_with_edges /src/dav1d/src/picture.c:125:15
    #5 0x52c7b4 in dav1d_thread_picture_alloc /src/dav1d/src/picture.c:156:9
    #6 0x54f4b3 in dav1d_submit_frame /src/dav1d/src/decode.c:3125:11
    #7 0x53427b in dav1d_parse_obus /src/dav1d/src/obu.c:1412:24
    #8 0x531926 in dav1d_get_picture /src/dav1d/src/lib.c:347:15
    #9 0x52bc70 in LLVMFuzzerTestOneInput /src/dav1d/tests/libfuzzer/dav1d_fuzzer.c:156:19
    #10 0x64b15a in ExecuteFilesOnyByOne(int, char**) /src/libfuzzer/afl/afl_driver.cpp:301:5
    #11 0x64b6be in main /src/libfuzzer/afl/afl_driver.cpp:339:12
    #12 0x7fce0494a82f in __libc_start_main /build/glibc-Cl5G7W/glibc-2.23/csu/libc-start.c:291

==1==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x5a4a74 in iclip /src/dav1d/include/common/intops.h:44:28
    #1 0x59adbe in put_bilin_c /src/dav1d/src/mc_tmpl.c:417:30
    #2 0x5d91ca in mc /src/dav1d/src/recon_tmpl.c:546:13
    #3 0x5cc844 in dav1d_recon_b_inter_8bpc /src/dav1d/src/recon_tmpl.c:1174:19
    #4 0x4e9f8f in decode_b /src/dav1d/src/decode.c:738:17
    #5 0x4cccc8 in decode_sb /src/dav1d/src/decode.c:1957:17
    #6 0x4c8b69 in dav1d_decode_tile_sbrow /src/dav1d/src/decode.c:2374:17
    #7 0x4ae294 in dav1d_tile_task /src/dav1d/src/thread_task.c:92:29
    #8 0x49f1ae in __msan::MsanThread::ThreadStart() /src/llvm/projects/compiler-rt/lib/msan/msan_thread.cc:77
    #9 0x7f5d7ded16b9 in start_thread
    #10 0x7f5d7d2dc41c in clone /build/glibc-Cl5G7W/glibc-2.23/sysdeps/unix/sysv/linux/x86_64/clone.S:109
  Uninitialized value was stored to memory at
    #0 0x45f31d in __msan_memcpy.part.51 /src/llvm/projects/compiler-rt/lib/msan/msan_interceptors.cc:1490
    #1 0x5a125d in emu_edge_c /src/dav1d/src/mc_tmpl.c:829:9
    #2 0x5d8f12 in mc /src/dav1d/src/recon_tmpl.c:535:13
    #3 0x5cc844 in dav1d_recon_b_inter_8bpc /src/dav1d/src/recon_tmpl.c:1174:19
    #4 0x4e9f8f in decode_b /src/dav1d/src/decode.c:738:17
    #5 0x4cccc8 in decode_sb /src/dav1d/src/decode.c:1957:17
    #6 0x4c8b69 in dav1d_decode_tile_sbrow /src/dav1d/src/decode.c:2374:17
    #7 0x4ae294 in dav1d_tile_task /src/dav1d/src/thread_task.c:92:29
    #8 0x49f1ae in __msan::MsanThread::ThreadStart() /src/llvm/projects/compiler-rt/lib/msan/msan_thread.cc:77
  Uninitialized value was created by a heap allocation
    #0 0x46bd54 in __interceptor_posix_memalign /src/llvm/projects/compiler-rt/lib/msan/msan_interceptors.cc:170
    #1 0x4a13a9 in dav1d_alloc_aligned /src/dav1d/include/common/mem.h:46:9
    #2 0x4a0e48 in default_picture_allocator /src/dav1d/src/picture.c:60:21
    #3 0x4a08c3 in fuzz_picture_allocator /src/dav1d/tests/libfuzzer/dav1d_fuzzer.c:66:12
    #4 0x4a1ce8 in picture_alloc_with_edges /src/dav1d/src/picture.c:125:15
    #5 0x4a17c8 in dav1d_thread_picture_alloc /src/dav1d/src/picture.c:156:9
    #6 0x4df71b in dav1d_submit_frame /src/dav1d/src/decode.c:3125:11
    #7 0x4b01eb in dav1d_parse_obus /src/dav1d/src/obu.c:1412:24
    #8 0x4aac80 in dav1d_get_picture /src/dav1d/src/lib.c:347:15
    #9 0x4a00de in LLVMFuzzerTestOneInput /src/dav1d/tests/libfuzzer/dav1d_fuzzer.c:156:19
    #10 0x6e69ab in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/libfuzzer/FuzzerLoop.cpp:571:15
    #11 0x69e956 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) /src/libfuzzer/FuzzerDriver.cpp:280:6
    #12 0x6af77a in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /src/libfuzzer/FuzzerDriver.cpp:713:9
    #13 0x69da81 in main /src/libfuzzer/FuzzerMain.cpp:20:10
    #14 0x7f5d7d1f582f in __libc_start_main /build/glibc-Cl5G7W/glibc-2.23/csu/libc-start.c:291