- Jan 25, 2022
-
-
Lyndon Brown authoredThere is no need to allocate strings in order to write the headers into the buffer. Opportunistically removed some hungarian notation.
-
Lyndon Brown authored
If `asprintf()` fails, the pointer is left in an unknown state. Should it fail when trying to construct the content type and/or role strings, the code would end up misusing the invalid pointers when trying to write data into the buffer to build the object, and when freeing the strings at the end. The preference given in review was for the function to take a failure path should these allocations fail. Note that the one caller already detects failure via a null object/buffer pointer being returned, as with the `calloc()` failure path, so this pointer is set to null prior to the new returns.
-
$(PROTOC) is set by the main Makefile already, thank you very much.
-
This is not necessary here, and it causes the whole contrib to fail on Linux distribution that provide a newer protoc than in VLC extra tools.
-
Disabling the binary is not enough. Its reverse dependencies also must be disabled.
-
-
We have to write all the fields anyway otherwise we get a warning
-
Rémi Denis-Courmont authored
-
Rémi Denis-Courmont authored
-
-
-
This is necessary to find "data-only" packages such as xproto and xcb-proto. xproto is not currently available in contribs, while xcb-proto seems completely broken in contribs (refs #26507).
-
This was supposed to prevent native .pc files of the build system being taken into use. But all this really did was add a directory to the search path. pkg-config environment variables are a little bit confusing: - PKG_CONFIG_PATH directories are searched first. By default, it is treated as empty. - PKG_CONFIG_LIBDIR directories are searched second. By default, the system native directories are searched, for instance /usr/lib/$(BUILD)/pkgconfig and /usr/share/pkgconfig. If we want to search in /usr/share/pkgconfig, then it should be added to LIBDIR where it would normally be. PATH is better suited for the contrib installation directory.
-
- Jan 24, 2022
-
-
-
-
-
-
it's broken and not required
-
They have zero cost in release and help pinpoint the component raising OpenGL issues.
-
The GLSL allows three different swizzling: - .rgba - .stuv - .xyzw However, they are not allowed to be mixed together: ERROR: 0:8: Inconsistent component characters in swizzle 'xa' ERROR: 0:10: Use of undeclared identifier 'pixel' ERROR: 0:11: Use of undeclared identifier 'result' Fix the swizzling to w instead of a.
-
- Jan 23, 2022
-
-
Rémi Denis-Courmont authored
The pkg-config file correctly supplies -pthread for LDFLAGS, but libtool discards it, leading to linkage failure if libupnp is linked statically.
-
We don't depend on OpenGL types for the signature anymore.
-
Create an header file containing the interop definition and operations, so that the entrypoint can also be implemented out-of-tree and doesn't depend on code from the modules/ directory.
-
The implementations are now independant of the vlc_gl_api_t structure and the OpenGL virtual table. The rationale for removing vlc_gl_api_t is that interop implementations are already required to load specific function for most of them (like the eglCreateImageKHR function) and having vlc_gl_api_t in the public module API require exposing the OpenGL vtable and types to the public scope, which is pretty ard to justify and port/maintain for every platform.
-
Avoid using vlc_gl_api_t to determine whether npot are usable or not and directly inline the same check from gl_api.c.
-
Allocate a private part for the interop containing the actual OpenGL vtable used by the interop "core" code.
-
Directly load the function in the call. This is not very pretty, but much easier to write than storing the pointer in a private part of the importer.
-
The API type is already available in the vlc_gl_t object.
-
This improves compatibility with the core profile for OpenGL and removes usage of the extension field from vlc_gl_api_t, to remove dependency from the interop to the vlc_gl_api_t.
-
Checking an extension is different between OpenGL compatibility profile or ES2 profile, and OpenGL core profile. Separating the call in a different function simplify the handling of those extension checks, and provides better compatibility with the core profile.
-
-
-
This removes the dependency from the vtable in vlc_gl_api_t, for future removal of the api from the interop API.
-
This removes the dependency from the vtable in vlc_gl_api_t, for future removal of the api from the interop API.
-
The surface type doesn't matter, especially since initialization for X11 is done by the decoder device now. All that matter is that the extension is available for the given context, providing access to the vdpau interop functions from this context.
-
This removes the dependency from the vtable in vlc_gl_api_t.
-
config.h is ought to be included in source files, not headers.
-
interop and picture_t definition are not needed in the header.
-
Only glBindTexture is used from the interop code, so remove the dependency from the vtable in vlc_gl_api_t altogether. The rationale for removing vlc_gl_api_t is that interop implementations are already required to load specific function for most of them (like the eglCreateImageKHR function) and having vlc_gl_api_t in the public module API require exposing the OpenGL vtable and types to the public scope, which is pretty ard to justify and port/maintain for every platform.
-
Rémi Denis-Courmont authored
libmpg123, xcb are not rebuildable in the current CI setup. upnp builds but breaks the VLC build (refs #24239).
-
