when probing muxers we don't really need the temporary file to exist in the
filesystem, we can use vlc_memfd() and pass along the file descriptor for
duplication in the file access module.

OutputNew() takes a new 'fd' param, and when probing we use that to pass
in the FD returned by vlc_memfd(), with a NULL for the path. Otherwise we
provide a path and -1 for 'fd'. If 'fd' is -1 it uses 'file' as the access
module and the specified path. If 'fd' is not -1, it uses the FD converted
to a string as the path and 'fd' as the access module. (same module,
different shortcut, which just triggers FD mode via the different access
name).

...based upon tmpfile() as suggested by Remi.

note, fixes use-after-free that would occur on non-windows should the
fprintf call be re-enabled. (psz_file was free'd in an earlier line).

the loop around the tmpfile() call, as per the comment, is to help get
around any possible 'delete-pending' failure situations on Windows. The
chosen loop count is arbritrary, just copying that of the vlc_mkstemp()
implementation used on Windows.

note, the code previously opened the file in O_WRONLY mode here, which has
changed to O_RDWR due to the underlying vlc_mkstemp() call used by
vlc_MakeTmpFile().

also note that the close of the FD is now done after reading the manifest,
such that for implementations of mkstemp that use exclusive access, we can
maintain that for the manifest reading (I presume it will not block the
second stream creation from the same process).

to reduce messy and duplicated code creating temporary files with
config_GetTempPath() and vlc_mkstemp().

created as an inline function since there will be so few users.

to avoid duplicated logic, and to remove pointless fallback on default
path should asprintf call fail.

param names have been changed to ones that make better sense.

one further small functional change is that vlc_mkdir() is now used even
in the default directory case, when it was not before. (reviewer requested
recursive style for handling null directory param).

and thus work properly cross platform

on posix/linux the $TMPDIR path should be preferred, using "/tmp" as a
fallback. we have not used our new config_GetTempPath() helper here in
order to avoid an unnecessary strdup.

to provide a common interface to the system/user temporary directory.

we will make use of this with vlc_mkstemp().

this has not been implemented into config_GetSysPath() or
config_GetUserDir() because it may return a system path in some cases
and a user path in others, so it does not perfectly fit either.

Zhao Zhili authored 4 years ago and Steve Lhomme committed 4 years ago

1. FF_THREAD_FRAME is in the FFmpeg code base since 2011.

2. codec/avcodec/video.c and codec/avcodec/directx_va.c use
FF_THREAD_FRAME directly without check.

3. FF_THREAD_FRAME is a thread type, it's not a multithreads decoding
support flag.

Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>

Zhao Zhili authored 4 years ago and Steve Lhomme committed 4 years ago

Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>

Zhao Zhili authored 4 years ago and Steve Lhomme committed 4 years ago

It's useless to set struct fields to NULL just before free the struct.

Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>

We should not rely on the old PTS values after a flush.

The macOS fix has been merged upstream.

  it is no longer dependant of the medialibrary

  isFocusOnContextButton no longer exists

  bookmark are stored in the medialibrary

Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

lower duration, set easing type sine