vdpau: hold the video context while cloning a picture context

modules/hw/vdpau/avcodec.c

@@ -112,9 +112,6 @@ static int Lock(vlc_va_t *va, picture_t *pic, AVCodecContext *ctx, AVFrame *fram
     if (field == NULL)
         return VLC_ENOMEM;
 
-    field->context.copy = VideoSurfaceCloneWithContext;
-    field->context.vctx = vlc_video_context_Hold(sys->vctx);
-
     pic->context = &field->context;
     frame->data[3] = (void *)(uintptr_t)field->frame->surface;
     return VLC_SUCCESS;

modules/hw/vdpau/picture.c

@@ -67,7 +67,7 @@ static picture_context_t *VideoSurfaceCopy(picture_context_t *ctx)
         return NULL;
 
     *fnew = *fold;
-
+    vlc_video_context_Hold(ctx->vctx);
     atomic_fetch_add(&fold->frame->refs, 1);
     return &fnew->context;
 }
@@ -127,9 +127,6 @@ VdpStatus vlc_vdp_video_attach(struct vlc_video_context *vctx,
     if (unlikely(field == NULL))
         return VDP_STATUS_RESOURCES;
 
-    field->context.destroy = VideoSurfaceDestroy;
-    field->context.copy = VideoSurfaceCloneWithContext;
-
     assert(pic->format.i_chroma == VLC_CODEC_VDPAU_VIDEO_420
         || pic->format.i_chroma == VLC_CODEC_VDPAU_VIDEO_422
         || pic->format.i_chroma == VLC_CODEC_VDPAU_VIDEO_444);