Khalid Masum authored 1 year ago and Steve Lhomme committed 1 year ago

75b62f44 aims to generalize
HAVE_GLES2 with the introduction of (!HAVE_GL and HAVE_GLES2)
and removes android specific library adding.

However, emscripen, like android falls into this criteria but not
removed. Hence libraries like libvlc_opengles.la is added twice and
causing error: "duplicate symbol" during shared module building.

Fix this by removing emscripten's block of code that causes this.

Fatih Uzunoğlu authored 1 year ago and Steve Lhomme committed 1 year ago

I18n module was intending to provide translation through vlc_gettext().
I'm not sure why QTranslator was not the way chosen before, because it
directly offers this and using qsTr() has the advantage of better integration.

Translation is handled in a lower abstraction level through QJSEngine
(see QJSEngine::TranslationExtension) as opposed to using custom a QML type
through QQmlEngine.

Thanks to that, the `org.videolan.vlc` module import can be eliminated
in some files.

This was forcing the subtitle region to become absolute. This will
later break subtitles in black bar which can be outside of the video
area. Absolute subtitle areas can only describe a position in the video
area.

This was also broken if the subpicture updater decides to set the region
position at each subpicture update. It would update the forced location
we set earlier.

We only need the entry channel order and the subpicture absolute, subtitle and original dimensions.

When they are displayed outside of the black bars they are not cleaned properly.

Only for display modules that render regions separately.

In case the absolute SPUs need shifting inside the video.

It stores exactly the same information, that's what we receive and there's a
comparison function.

Missing parts from 4f37f30c.

It was only used by the display modules rendering (scaled) regions.
That was always set to the video placement dimensions in the display, which they already know about.

It doesn't matter if we scale up or down. They do the same kind of scaling.

Fatih Uzunoğlu authored 1 year ago and Steve Lhomme committed 1 year ago

LabelExt shows tool tip by default if its
width is not sufficient.

Fatih Uzunoğlu authored 1 year ago and Jean-Baptiste Kempf committed 1 year ago

QStringView is available on Qt 5.12, but lacks the split() method
that is used here.

Fatih Uzunoğlu authored 1 year ago and Jean-Baptiste Kempf committed 1 year ago

QRhiD3D11 uses functionality that is expected
to be not available on Windows 7. Since RHI
fallback does not work, we force OpenGL so
that it does not crash.

Fatih Uzunoğlu authored 1 year ago and Jean-Baptiste Kempf committed 1 year ago

Qt docs: The color buffer is cleared by default.