1. 25 Jan, 2023 4 commits
    • Alexandre Janniaux's avatar
      test: medialibrary: check that thumbnailing works · 277d7311
      Alexandre Janniaux authored and Tristan Matthews's avatar Tristan Matthews committed
      The test creates a libvlc instance with a medialibrary and check that
      the medialibrary can generate a mock thumbnail for a given mock:// URL
      with different parameters.
      
      Multiple improvements can be done from here: in particular, the
      medialibrary will insist in loading its discovery modules, whereas we
      only need to check whether the thumbnailing work in this current test.
      Some work needs to be done to evaluate whether it's interesting enough
      to cut those discovery modules out for this test or extend the scenario
      to other cases like testing those discovery modules.
      
      Regression testing from #27749
      277d7311
    • Alexandre Janniaux's avatar
      medialibrary: dump location path for medialibrary · 4791527a
      Alexandre Janniaux authored and Tristan Matthews's avatar Tristan Matthews committed
      The location helps determine where the user loaded the medialibrary
      from.
      4791527a
    • Alexandre Janniaux's avatar
      medialibrary: init ML before adding media · 603afb47
      Alexandre Janniaux authored and Tristan Matthews's avatar Tristan Matthews committed
      When calling VLC_ML_NEW_EXTERNAL_MEDIA or VLC_ML_NEW_STREAM, the
      medialibrary must be initialized because the priority context is
      acquired, just list for the VLC_ML_GENERATE_THUMBNAIL request.
      
      Ensure the medialibrary is initialized at the same location as other
      queries like this.
      603afb47
    • Alexandre Janniaux's avatar
      medialibrary: Thumbnailer: fix double-free · a41743de
      Alexandre Janniaux authored and Tristan Matthews's avatar Tristan Matthews committed
      The picture was referenced on the ThumbnailerCtx object, which release
      it whenever one is not nullptr. However, after the changes in !3088,
      commit 2ea2c7eb, the release policy for
      the picture being exported has been fixed to ensure the picture is
      consumed whatever the conversion case.
      
      Ensure the picture won't be released twice by swapping it from the
      ThumbnailerCtx object before exporting.
      
      Fix #27749
      a41743de
  2. 24 Jan, 2023 17 commits
  3. 23 Jan, 2023 6 commits
  4. 21 Jan, 2023 13 commits