The spec subtracts the signed offset from all of these when using them,
like it does for e.g. ar_coeffs_y_plus_128, although for some reason
the naming scheme is inconsistent here. Either way, it makes more sense
to treat them as signed integers than unsigned integers.

To avoid confusion since the name of the field is the same as the one in
the spec, we mark the type as int8_t (resp. int16_t for the 9-bit field)
to make it clear to the user that these are already signed integers.

This is similar to --noblit of libaom

oss-fuzz builds the fuzzing binary out of meson. Local (quoted) includes
should be preferred for headers located in the same directory.

Instead of bit reverting the register subtract 24 from clz. This avoids
two empty filler values in the jump table with the same instruction
count.

Missed in 46e2a2d0. Arm asm will be hard to template so move them to
the plain source list.

Fix #96.

Marvin Scholz authored 6 years ago and Ronald S. Bultje committed 6 years ago

Fix #96

Add duplicate prototypes to ref_mvs.c for now, since ref_mvs.h can't
be included.

Signed-off-by: James Almer <jamrial@gmail.com>

Martin Storsjö authored 6 years ago and Ronald S. Bultje committed 6 years ago

For arm/arm64, there's no need to align any buffer to 32 bytes
as the assembly doesn't need it and doesn't benefit from it.

This would be much more elegant if defined like this:

    #define MAX_ALIGN 16
    #define ALIGN(align) __attribute__((aligned(MIN(align, MAX_ALIGN))))

This works for GCC and Clang, but the MSVC alignment __declspec
needs a literal alignment value, it can't handle an expression.

Janne Grunau authored 6 years ago and Ronald S. Bultje committed 6 years ago

Fixes an undefined left shift in
clusterfuzz-testcase-minimized-dav1d_fuzzer-5717082881130496. Credits to
oss-fuzz. Fixes #110

Janne Grunau authored 6 years ago and Ronald S. Bultje committed 6 years ago

Due to the stripe offset of 8 rows the last stripe can have a height of
128 + 8 rows if the resolution is a multiple of 128. Fixes a
stack-buffer-overflow in
clusterfuzz-testcase-minimized-dav1d_fuzzer-5731418676658176. Credits to
oss-fuzz.

Fix issue #70

These went out of sync in 227b7eae.

checkasm --bench numbers from a Snapdragon 835:
nop: 23.0
avg_w4_8bpc_c: 385.0
avg_w4_8bpc_neon: 34.0
avg_w8_8bpc_c: 590.5
avg_w8_8bpc_neon: 65.5
avg_w16_8bpc_c: 1304.4
avg_w16_8bpc_neon: 161.3
avg_w32_8bpc_c: 4098.4
avg_w32_8bpc_neon: 589.2
avg_w64_8bpc_c: 8405.0
avg_w64_8bpc_neon: 1367.1
avg_w128_8bpc_c: 19667.9
avg_w128_8bpc_neon: 3409.0
w_avg_w4_8bpc_c: 453.8
w_avg_w4_8bpc_neon: 50.0
w_avg_w8_8bpc_c: 749.0
w_avg_w8_8bpc_neon: 105.7
w_avg_w16_8bpc_c: 1851.2
w_avg_w16_8bpc_neon: 283.7
w_avg_w32_8bpc_c: 5991.5
w_avg_w32_8bpc_neon: 1080.9
w_avg_w64_8bpc_c: 12763.5
w_avg_w64_8bpc_neon: 2544.4
w_avg_w128_8bpc_c: 30311.3
w_avg_w128_8bpc_neon: 6350.5
mask_w4_8bpc_c: 492.9
mask_w4_8bpc_neon: 57.7
mask_w8_8bpc_c: 1108.5
mask_w8_8bpc_neon: 123.0
mask_w16_8bpc_c: 2880.3
mask_w16_8bpc_neon: 349.2
mask_w32_8bpc_c: 8996.4
mask_w32_8bpc_neon: 1368.1
mask_w64_8bpc_c: 19570.3
mask_w64_8bpc_neon: 3263.5
mask_w128_8bpc_c: 46757.4
mask_w128_8bpc_neon: 8743.1

Fixes #100.

Fixes #104.

Ronald S. Bultje authored 6 years ago and Janne Grunau committed 6 years ago

Fixes #93.

This reverts commit 6fa9df9c. The
behaviour shown there only happens when show_existing_frame=1, i.e.
it was the same bug as 2e991b14.

Remove debug code under '#if !defined(NDEBUG)' still using av_clamp_mv().

Parse and use it instead.

Signed-off-by: James Almer <jamrial@gmail.com>

This is more in line with the behavior from libaom.

Signed-off-by: James Almer <jamrial@gmail.com>

Fixes #97.

Refs #97.

Fixes #64.

Ronald S. Bultje authored 6 years ago and Janne Grunau committed 6 years ago

Fixes #92.

Ronald S. Bultje authored 6 years ago and Janne Grunau committed 6 years ago

This is identical to what libaom does for such OBUs. It prevents us
from doing block decoding, which doesn't make sense for such OBUs,
and would result in using an uninitialized frame header during the
decoding process. Fixes #94.

Ronald S. Bultje authored 6 years ago and Janne Grunau committed 6 years ago

Fixes #89.

Ronald S. Bultje authored 6 years ago and Janne Grunau committed 6 years ago

Otherwise, if the non-last has a max value, the ones after it can go
beyond the allowed range. Fixes #95.

Fixes #90.

Janne Grunau authored 6 years ago and Ronald S. Bultje committed 6 years ago

Fixes #97.

Janne Grunau authored 6 years ago and Ronald S. Bultje committed 6 years ago

See #97.

Martin Storsjö authored 6 years ago and Janne Grunau committed 6 years ago

For MachO, this makes sure that the label difference actually is
evaluated at assembly time (as it already was for ELF and COFF);
evaluating it at link time failed when the difference is stored in
a .hword.

This fixes linking errors like these:
ld: in section __TEXT,__text reloc 0: ARM64_RELOC_SUBTRACTOR must have r_length of 2 or 3 file 'src/src@@dav1d_bitdepth_8@sta/arm_64_mc.S.o' for architecture arm64

This adds an asm.S macro for decorating a symbol for making a
local symbol. For armasm64 with gas-preprocessor, this doesn't
actually create a local label (but neither do the local numbered
labels either currently), which might be slightly inconsistent
in it would be necessary to make the distinction for that assembler
as well.

Alternatively, the table symbol could be made into a plain local
numbered label as all the other labels.

Janne Grunau authored 6 years ago and Ronald S. Bultje committed 6 years ago

Fixes 9 warnings. See #97.