Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
U
Unity
Manage
Activity
Members
Labels
Plan
Issues
0
Issue boards
Milestones
Wiki
Code
Merge requests
0
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Shane Veasy
Unity
Commits
d270da9b
Commit
d270da9b
authored
7 years ago
by
Stanley Goldman
Browse files
Options
Downloads
Patches
Plain Diff
Removing command output from log of ProcessTask; Leaving a warning
parent
5edeff30
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/GitHub.Api/Tasks/ProcessTask.cs
+8
-5
8 additions, 5 deletions
src/GitHub.Api/Tasks/ProcessTask.cs
with
8 additions
and
5 deletions
src/GitHub.Api/Tasks/ProcessTask.cs
+
8
−
5
View file @
d270da9b
...
...
@@ -13,8 +13,8 @@ namespace GitHub.Unity
private
const
string
ProcessKey
=
"process"
;
private
const
string
TypeKey
=
"type"
;
private
readonly
StringWriter
error
=
new
StringWriter
();
private
readonly
StringWriter
output
=
new
StringWriter
();
private
readonly
StringWriter
error
Buffer
=
new
StringWriter
();
private
readonly
StringWriter
output
Buffer
=
new
StringWriter
();
private
readonly
IProcessManager
processManager
;
private
readonly
IEnvironment
environment
;
private
readonly
ITaskResultDispatcher
<
string
>
resultDispatcher
;
...
...
@@ -290,7 +290,10 @@ namespace GitHub.Unity
{
var
output
=
OutputBuffer
.
ToString
().
Trim
();
Logger
.
Trace
(
"Success: \"{0}\""
,
output
);
//Note: Do not log success output, as it may contain sensitive data
//Logger.Trace("Success: \"{0}\"", output);
Logger
.
Trace
(
"Success"
);
resultDispatcher
?.
ReportSuccess
(
output
);
}
...
...
@@ -331,8 +334,8 @@ namespace GitHub.Unity
protected
virtual
CachedTask
CachedTaskType
{
get
{
return
CachedTask
.
ProcessTask
;
}
}
protected
StringWriter
OutputBuffer
{
get
{
return
output
;
}
}
protected
StringWriter
ErrorBuffer
{
get
{
return
error
;
}
}
protected
StringWriter
OutputBuffer
{
get
{
return
output
Buffer
;
}
}
protected
StringWriter
ErrorBuffer
{
get
{
return
error
Buffer
;
}
}
protected
IProcessManager
ProcessManager
=>
processManager
;
protected
IEnvironment
Environment
=>
environment
;
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment