Skip to content
Snippets Groups Projects
  1. Jan 31, 2025
  2. Jan 30, 2025
    • Marvin Scholz's avatar
      macosx: use correct variable names for actual arch · b202da71
      Marvin Scholz authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
      This is used in other places in the script and if unset leads to the
      `-arch` argument being passed without any architecture, which is invalid
      and causes compiler invocations to fail.
      
      The reason this worked in CI is that the build script overwrites the
      ACTUAL_HOST_ARCH as it can be changed by an argument. However the
      env.build.sh script is used also outside the build.sh script in
      manual build scenarios, which is the whole reason it is a separate
      script to begin with.
      b202da71
    • Alexandre Janniaux's avatar
      logger: add telegraf tracer · e8e46b0d
      Alexandre Janniaux authored
      The tracer is designed to send the metrics towards a telegraf server
      using this kind of configuration:
      
          [[inputs.socket_listener]]
          service_address = "tcp://localhost:8094"
      
      The telegraf server can then forward the metrics towards an influxdb
      server for monitoring or directly to grafana live server[^1] for
      introspection.
      
      The influxdb database can also be used to query the metrics after
      they've been indexed.
      
      The application using the tracer can use the VLC_TELEGRAF_ENDPOINT
      environment variable (eg. VLC_TELEGRAF_ENDPOINT=tcp://127.0.0.1:8094)
      to set where the tracer will output the traces to.
      
      A bunch of notes and improvement left for later:
      
       - Unsafe code is still used for accessing the fields data since an
         union is used and union access is unsafe. It could probably be
         wrapped from the binding implementation.
      
       - There is no way to specify the address using the configuration
         since vlc_variable is not bound to the Rust bindings and no
         unsafe extern "C" code...
      e8e46b0d
    • Alexandre Janniaux's avatar
      vlcrs-core: add tracer capability bindings · 3a3b5d67
      Alexandre Janniaux authored
      This commit allows rust code to use the tracer API, through the trace!()
      macro, and also exposes a TracerCapability and TracerModuleLoader to
      create new tracer modules in Rust.
      3a3b5d67
    • Pierre Lamot's avatar
      contrib: run RECONF in dvdnav · fd7e1136
      Pierre Lamot authored and Steve Lhomme's avatar Steve Lhomme committed
      As configure.ac is patched
      fd7e1136
    • Thomas Guillem's avatar
      es_out: remove unused es_cat array · 500b8e2a
      Thomas Guillem authored and Steve Lhomme's avatar Steve Lhomme committed
      Forgot to remove this leftover from 709610a2
      
      EsOutGetFromID() was made obsolete in a88c34e6
      500b8e2a
    • Steve Lhomme's avatar
      vt_utils: fix define checks · 7205d862
      Steve Lhomme authored
      7205d862
    • Steve Lhomme's avatar
      access: dvb: avoid casting callbacks · bbc22577
      Steve Lhomme authored
      bbc22577
    • Steve Lhomme's avatar
      mux: ts: avoid casting callbacks · 73f3e7c5
      Steve Lhomme authored
      73f3e7c5
  3. Jan 29, 2025
    • Alaric Senat's avatar
      configure: misc: fix some typos · a7f92685
      Alaric Senat authored and Steve Lhomme's avatar Steve Lhomme committed
      a7f92685
    • Alaric Senat's avatar
      emscripten: extra_checks: ban incompatible function casts · c876b0f7
      Alaric Senat authored and Steve Lhomme's avatar Steve Lhomme committed
      Emscripten is known to deal badly with function casts to incompatible
      types [^1]. This patch prevent us to accidentally merge harmful UB casts
      to wasm enabled code. The warning is really strict but is compliant to the
      standard. Code that wants to use function cast should be disabled from
      the wasm platform.
      
      [^1]: https://emscripten.org/docs/porting/guidelines/function_pointer_issues.html
      c876b0f7
    • Alaric Senat's avatar
      libplacebo: avoid casting callbacks · e99be279
      Alaric Senat authored and Steve Lhomme's avatar Steve Lhomme committed
      The function signature does not match the libplacebo callback (gl_t*
      instead of void*). While this is supported by many platforms and
      compilers, it's undefined behavior strictly by the standard [1] and it's
      known to often fail with emscripten [^2].
      
      [1]:
      Section 6.3.2.3, paragraph 8:
      
      > A pointer to a function of one type may be converted to a pointer to a
      > function of another type and back again; the result shall compare
      > equal to the original pointer. If a converted pointer is used to call
      > a function whose type is not compatible with the pointed-to type, the
      > behavior is undefined.
      
      Quoting section 6.7.5.1, paragraph 2 for pointer compatibility:
      
      > For two pointer types to be compatible, both shall be identically
      > qualified and both shall be pointers to compatible types.
      
      
      [^2]: https://emscripten.org/docs/porting/guidelines/function_pointer_issues.html
      e99be279
    • Alaric Senat's avatar
      mpeg: dvbpsi: avoid casting callbacks · 61c4034f
      Alaric Senat authored and Steve Lhomme's avatar Steve Lhomme committed
      The function signature does not match the dvbpsi callback (demux_t*
      instead of void*). While this is supported by many platforms and
      compilers, it's undefined behavior strictly by the standard [1] and it's
      known to often fail with emscripten [^2].
      
      [1]: 
      Section 6.3.2.3, paragraph 8:
      
      > A pointer to a function of one type may be converted to a pointer to a
      > function of another type and back again; the result shall compare
      > equal to the original pointer. If a converted pointer is used to call
      > a function whose type is not compatible with the pointed-to type, the
      > behavior is undefined.
      
      Quoting section 6.7.5.1, paragraph 2 for pointer compatibility:
      
      > For two pointer types to be compatible, both shall be identically
      > qualified and both shall be pointers to compatible types.
      
      
      [^2]: https://emscripten.org/docs/porting/guidelines/function_pointer_issues.html
      61c4034f
    • Steve Lhomme's avatar
      keystore: avoid dirty function pointer casts · 837f9778
      Steve Lhomme authored
      Especially when mixing LPCWSTR and LPWSTR*.
      837f9778
    • Maxime Chapelet's avatar
      contribs: png: disable debug lib suffix for all platforms · 9858ba5d
      Maxime Chapelet authored and Steve Lhomme's avatar Steve Lhomme committed
      Given contribs are bootstrapped with `--disable-optimizations` option,
      the CMAKE flag `-DCMAKE_BUILD_TYPE` is set to `Debug`, and when
      build configuration is set to `Debug` in libpng contrib, it CMAKE
      configuration append a `d` char to the static library name,
      resulting in a lib named `libpng16d.a` instead of `libpng16.a`.
      Then some vlc module depending on libpng aren't able to link
      properly as they can't find their lpng16 dependency.
      9858ba5d
  4. Jan 28, 2025
Loading