- Apr 09, 2014
-
-
Jean-Baptiste Kempf authored
-
Jean-Baptiste Kempf authored
-
Jean-Baptiste Kempf authored
-
Jean-Baptiste Kempf authored
-
Jean-Baptiste Kempf authored
-
Jean-Baptiste Kempf authored
-
Jean-Baptiste Kempf authored
-
Jean-Baptiste Kempf authored
-
- Mar 30, 2014
-
-
Signed-off-by: Timothy Gu <timothygu99@gmail.com> Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
-
- Mar 02, 2014
-
-
This ensures that the dvd_reader_t struct is initialized (e.g. the css_state field is currently undefined if 'have_css' is false). The patch is part of a bigger MythTV-specific change by Chris Pinkham: https://github.com/MythTV/mythtv/commit/3af3489 Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
-
As many compile time defines are now in config.h it should be included in all .c files at the top. (this allows support for large DVDs (>2GB) again.) Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
-
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
-
- Feb 20, 2014
-
-
Diego Elio Pettenò authored
Without adding m4 to the list of included directories, attributes.m4 is not found and will fail to expand the CC_* macros.
-
- Feb 18, 2014
-
-
In dvd_reader.c, the DVDDiscID function gets the MD5 from the total contents of the IFO files on the disc. However, it gets it by looping through the the first ten IFO files, whether they exist or not. This results in spewage, where a disc has less than ten. In this case, Dragonheart only has two: libdvdnav:DVDOpenFileUDF:UDFFindFile /VIDEO_TS/VTS_03_0.IFO failed libdvdnav:DVDOpenFileUDF:UDFFindFile /VIDEO_TS/VTS_04_0.IFO failed libdvdnav:DVDOpenFileUDF:UDFFindFile /VIDEO_TS/VTS_05_0.IFO failed libdvdnav:DVDOpenFileUDF:UDFFindFile /VIDEO_TS/VTS_06_0.IFO failed libdvdnav:DVDOpenFileUDF:UDFFindFile /VIDEO_TS/VTS_07_0.IFO failed libdvdnav:DVDOpenFileUDF:UDFFindFile /VIDEO_TS/VTS_08_0.IFO failed libdvdnav:DVDOpenFileUDF:UDFFindFile /VIDEO_TS/VTS_09_0.IFO failed Instead of using a set limit of 10 IFOs, this patch counts the number of VTSes existing on the DVD, and will use that number instead if it is less than 10. Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
-
- Jan 09, 2014
-
-
Jean-Baptiste Kempf authored
-
Jean-Baptiste Kempf authored
-
Jean-Baptiste Kempf authored
-
Jean-Baptiste Kempf authored
-
Jean-Baptiste Kempf authored
-
- Jan 02, 2014
-
-
Diego Biurrun authored
navPrint_PCI_GI() prints the values of a pci_gi_t struct, but for the embedded user_ops_t substruct it just prints the first 32 bytes by pointer type punning. Given that the latter is a large struct with members of system-dependent sizes the result of this operation is often enough just a random value, so drop printing the value altogether. src/nav_print.c:39:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
-
Diego Biurrun authored
-
Diego Biurrun authored
src/ifo_read.c:1402:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
-
Diego Biurrun authored
src/dvd_reader.c:1384:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
-
Diego Biurrun authored
src/ifo_read.c:1078:13: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t' [-Wformat=]
-
Diego Biurrun authored
src/ifo_read.c:1303:34: warning: comparison between pointer and integer [enabled by default]
-
Jean-Baptiste Kempf authored
Else, we will not get the HAVE_DVDCSS_DVDCSS_H define and the code will not work when statically compiled. It might be clever to remove that in the future, but one would need to fix the code for that.
-
- Dec 29, 2013
-
-
Jean-Baptiste Kempf authored
And kill a warning
-
Jean-Baptiste Kempf authored
This makes sense since it is used as a malloc' size. And add a check in case it would have been negative
-
Signed-off-by: Erik Hovland <erik@hovland.org> Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>
-
Both GCC 4.8.2 and Clang 3.4 warn about a format mismatch in a comparison. libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../src -mno-ms-bitfields -O3 -Wall -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOUR CE -MT ifo_read.lo -MD -MP -MF .deps/ifo_read.Tpo -c ifo_read.c -fPIC -DPIC -o .libs/ifo_read.o […] ifo_read.c: In function 'ifoRead_PTL_MAIT': ifo_read.c:1313:34: warning: comparison between pointer and integer [enabled by default] if(ifofile->vmgi_mat->ptl_mait == NULL) libtool: compile: clang -DHAVE_CONFIG_H -I. -I.. -I.. -I../src -O3 -Wall -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -MT ifo_read. lo -MD -MP -MF .deps/ifo_read.Tpo -c ifo_read.c -fPIC -DPIC -o .libs/ifo_read.o […] ifo_read.c:1313:34: warning: comparison between pointer and integer ('uint32_t' (aka 'unsigned int') and 'void *') if(ifofile->vmgi_mat->ptl_mait == NULL) ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~ Fix this by using the integer 0 instead of `NULL`.
-
The static analyzer from LLVM/Clang 1:3.4~svn194079-1 reports a possible allocation of size 0 in `libdvdread/src/ifo_read.c`. $ scan-build -o scan-build make $ scan-view scan-build/2013-11-18-155601-16168-1 When `vts_ptt_srpt->nr_of_srpts` is zero the allocation size is zero. vts_ptt_srpt->title = malloc(vts_ptt_srpt->nr_of_srpts * sizeof(ttu_t)); The manual of the function `malloc` writes the following. If size is 0, then malloc() returns either NULL, or a unique pointer value that can later be successfully passed to free(). So check for 0 and, if it is, abort by going to the label `fail`.
-
The static analyzer from LLVM/Clang 1:3.4~svn194079-1 reports a memory leak in `libdvdread/src/dvd_udf.c`. $ scan-build -o scan-build make $ scan-view scan-build/2013-11-18-155601-16168-1 The memory is allocated in if((cached_dir_base = malloc(dir_lba * DVD_VIDEO_LB_LEN + 2048)) == NULL) and has to be freed before returning from the function. Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
-
-
Jean-Baptiste Kempf authored
-
Jean-Baptiste Kempf authored
-
- Nov 30, 2013
-
-
Diego Biurrun authored
-
- Nov 18, 2013
-
-
This fixes the ChangeLog file getting continuously rebuilt instead of after each Git commit, which is the case now.
-
Jean-Baptiste Kempf authored
-
Jean-Baptiste Kempf authored
-
Jean-Baptiste Kempf authored
-