This disables the bottom tab bar hack in order to properly have a
side bar navigation on iPad.

The side bar navigation is now enabled on iPad running iPadOS 18
and versions above.

This is a wip prototype that was aimed to check the amount of work
needed in order to make this happen.

Currently each tab of the Audio section are made as proper navigation
tabs in that side bar only to avoid any huge refactor around the
PagingViewController and related classes.

A proper view controller is now handling each tab of the Audio section.

This can be used to create a proper navigation tab without having to use
the paging view controller.

The tab bar icons now have a proper color that can be set when new
tabs are created.

The collection view and search bar constraints are now aligned to the
safe area to avoid any unexpected offset when the side bar will be
displayed.

The mini player's bottom constraint is now aligned with the
rootViewController in order to properly display the player
when the bottom tab bar is hidden.

The buttonBarView's constraints are now aligned with the safe area
witout the use of left and right anchors.

The containerView's bottom constraint is now aligned with the view's
bottom anchor to properly show the container over the safe area since
the bottom bar is hidden.

- This solves a crash on launch on OS versions without this framework
- Regression from !1383

Craig Reyenga authored 2 months ago and Felix Paul Kühne committed 2 months ago

- create new implementation
- greatly improve accessibility

Diogo Simao Marques authored 2 months ago and Felix Paul Kühne committed 2 months ago

The play all button is now hidden when necessary to avoid having it being
displayed when the view is empty.

Diogo Simao Marques authored 2 months ago and Felix Paul Kühne committed 2 months ago

The activity indicator is now properly stopped when the folder selected has
already been parsed and is empty.

Diogo Simao Marques authored 3 months ago and Felix Paul Kühne committed 2 months ago

The margins and bottom constraint of the current view controller are
adjusted in order to properly be able to fix the mini player if needed.

Diogo Simao Marques authored 3 months ago and Felix Paul Kühne committed 2 months ago

The edit tool bar's bottom constraint is now aligned to the safe area
in order to avoid any visual glitch and remove the Xcode generated warning
forcing the change.

Diogo Simao Marques authored 3 months ago and Felix Paul Kühne committed 2 months ago

BottomTabBarController overrides the UITabBarController and displays
the previous tab bar layout at the bottom of the screen.

These changes only apply to iPads running with iPadOS 18.0 and versions
above it.

Diogo Simao Marques authored 3 months ago and Felix Paul Kühne committed 2 months ago

The .opticID switch case was previously removed and was generating a
warning which could lead to an error in Xcode 6.0

Diogo Simao Marques authored 3 months ago and Felix Paul Kühne committed 2 months ago

The coding style has been reviewed and a few chunks of code have been
simplified.

Diogo Simao Marques authored 3 months ago and Felix Paul Kühne committed 2 months ago

This setting enables the user to automatically enable the rotation
lock option when the video player is displayed.

The orientation that will be locked is the one selected by the device
when the video player is displayed for the first time.
It remains the same until the option is disabled or the video player is
killed.

Closes #1869

The icon used for the aspect ratio is now more explicit.

Closes #1852