Johannes Kauffmann authored 1 year ago and Rémi Denis-Courmont committed 1 year ago

These defines are available since MinGW-W64 v2.0.

Steve Lhomme authored 1 year ago and Rémi Denis-Courmont committed 1 year ago

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Alaric Senat authored 1 year ago and Rémi Denis-Courmont committed 1 year ago

Instead of increasing it at each ES addition. The previous behavior was
wrongly incrementing the playlist count when multiple ES were muxed in
the same playlist.

Alaric Senat authored 1 year ago and Rémi Denis-Courmont committed 1 year ago

Variant parsing failure already clears the variant map. Calling
`hls_variant_maps_Destroy()` a second time was trigerring a double free.

Thomas Guillem authored 1 year ago and Rémi Denis-Courmont committed 1 year ago

vlc_player_Start() could have 0 effects when the input was being deleted
while the user requested to play it again.

Alexandre Janniaux authored 1 year ago and Rémi Denis-Courmont committed 1 year ago

The C++ wrapper is simpler to write and would initialize C++ objects
correctly, though they are not required here.

Alexandre Janniaux authored 1 year ago and Rémi Denis-Courmont committed 1 year ago

The code is already defending against nullptr since multiple clients can
destroy the pointer, and the compositor might not be allocated in the
situation where Qt is allocated as a dialog provider, so there is no
reason to not use std::unique_ptr here.

Previous commits also ensure that vlc_object_create<>() will correctly
initialize C++ objects, and vlc_object_destroy<>() will correctly
destroy them.

No functional changes.