Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
VLC-QT
Manage
Activity
Members
Labels
Plan
Issues
0
Issue boards
Milestones
Code
Merge requests
0
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Model registry
Operate
Terraform modules
Monitor
Service Desk
Analyze
Contributor analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Chandrakant Jena
VLC-QT
Commits
96caf7e8
Commit
96caf7e8
authored
2 years ago
by
Benjamin Arnaud
Committed by
Jean-Baptiste Kempf
2 years ago
Browse files
Options
Downloads
Patches
Plain Diff
qml/VideoDisplayRecentVideos: Fix positioning and margins
parent
ba2f6837
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
modules/gui/qt/medialibrary/qml/VideoAllSubDisplay.qml
+8
-5
8 additions, 5 deletions
modules/gui/qt/medialibrary/qml/VideoAllSubDisplay.qml
modules/gui/qt/medialibrary/qml/VideoDisplayRecentVideos.qml
+8
-8
8 additions, 8 deletions
modules/gui/qt/medialibrary/qml/VideoDisplayRecentVideos.qml
with
16 additions
and
13 deletions
modules/gui/qt/medialibrary/qml/VideoAllSubDisplay.qml
+
8
−
5
View file @
96caf7e8
...
...
@@ -220,16 +220,19 @@ VideoAll {
}
header
:
VideoDisplayRecentVideos
{
width
:
root
.
width
width
:
root
.
width
-
displayMarginBeginning
-
displayMarginEnd
subtitleText
:
(
root
.
model
&&
root
.
model
.
count
>
0
)
?
I18n
.
qtr
(
"
Videos
"
)
:
""
// NOTE: We want grid items to be visible on the sides.
leftPadding
:
root
.
contentMargin
x
:
displayMarginBeginning
// spacing between header and content
bottomPadding
:
VLCStyle
.
margin_normal
subtitleText
:
(
root
.
model
&&
root
.
model
.
count
>
0
)
?
I18n
.
qtr
(
"
Videos
"
)
:
""
// NOTE: We want grid items to be visible on the sides.
displayMarginBeginning
:
root
.
contentMargin
displayMarginEnd
:
displayMarginBeginning
Navigation.parentItem
:
root
Navigation.downAction
:
function
()
{
...
...
This diff is collapsed.
Click to expand it.
modules/gui/qt/medialibrary/qml/VideoDisplayRecentVideos.qml
+
8
−
8
View file @
96caf7e8
...
...
@@ -30,11 +30,13 @@ import "qrc:///style/"
FocusScope
{
id
:
root
property
alias
leftPadding
:
recentVideosColumn
.
leftPadding
property
alias
rightPadding
:
recentVideosColumn
.
rightPadding
property
alias
topPadding
:
recentVideosColumn
.
topPadding
// Aliases
property
alias
bottomPadding
:
recentVideosColumn
.
bottomPadding
property
alias
displayMarginBeginning
:
listView
.
displayMarginBeginning
property
alias
displayMarginEnd
:
listView
.
displayMarginEnd
property
alias
subtitleText
:
subtitleLabel
.
text
// Settings
...
...
@@ -70,13 +72,15 @@ FocusScope {
Widgets.SubtitleLabel
{
text
:
I18n
.
qtr
(
"
Continue Watching
"
)
// NOTE: Setting this to listView.visible seems to causes unnecessary implicitHeight
// calculations in the Column parent.
visible
:
listView
.
count
>
0
}
Widgets.KeyNavigableListView
{
id
:
listView
width
:
roo
t
.
width
-
root
.
leftPadding
-
root
.
rightPadding
width
:
paren
t
.
width
implicitHeight
:
VLCStyle
.
gridItem_video_height
+
VLCStyle
.
gridItemSelectedBorder
+
...
...
@@ -84,10 +88,6 @@ FocusScope {
spacing
:
VLCStyle
.
column_margin_width
// NOTE: Sometimes, we want items to be visible on the sides.
displayMarginBeginning
:
root
.
leftPadding
displayMarginEnd
:
root
.
rightPadding
// NOTE: We want navigation buttons to be centered on the item cover.
buttonMargin
:
VLCStyle
.
margin_xsmall
+
VLCStyle
.
gridCover_video_height
/
2
-
buttonLeft
.
height
/
2
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment