In order to hold more variables per filter, cf. next commits.

Mehdi Sabwat authored 3 years ago and Felix Paul Kühne committed 3 years ago

ubsan is enabled in the contrib recipe :
https://bitbucket.org/mpyne/game-music-emu/src/b3d158a30492181fd7c38ef795c8d4dcfd77eaa9/CMakeLists.txt#lines-67

This will require vlc to be always built with ubsan and we don't want this in production.

Alexandre Janniaux authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

pl-output-hint is an integer variable, and it was leading to warnings
when compiling:

    ../../modules/video_output/libplacebo/display.c: In function 'UpdateColorspaceHint':
    ../../modules/video_output/libplacebo/display.c:499:5: warning: case label value exceeds maximum value for type [-Wswitch-outside-range]
      499 |     case OUTPUT_HDR10:
          |     ^~~~
    ../../modules/video_output/libplacebo/display.c:503:5: warning: case label value exceeds maximum value for type [-Wswitch-outside-range]
      503 |     case OUTPUT_HLG:
          |     ^~~~
    ../../modules/video_output/libplacebo/display.c:477:5: warning: switch condition has boolean value [-Wswitch-bool]
      477 |     switch (var_InheritBool(vd, "pl-output-hint")) {
          |     ^~~~~~

Thomas Guillem authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Regression from 31f97cbe

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

GL_RED and GL_RG are available since OpenGL 3.0 and OpenGL ES 3.0, or
via OpenGL extensions.

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Extract version check to a separate static inline function.

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

The function opengl_interop_init() is now used only by interop_sw().

Move its implementation and remove the init() callback.

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This prepares further commits.

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Free the private instance on error.

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

All interop modules reused the util function opengl_interop_init()
(written for the software interop) to initialize the textures properties
from the chroma.

However, the actual texture format may not always be deduced from the
chroma: only the interop implementations have the full knowledge of the
texture details.

Therefore, initialize texture properties directly from each interop
implementation.

Fixes #26735
Fixes #26769

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This will allow to call this function from interop modules.

This function is currently called from opengl_interop_init_impl() (the
init function pointer), which will be removed (so this narrows the scope
of helpers code exposed to modules).

In the future, more work will be needed to also remove this function
pointer.

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

The interop determines the format (currently based on the chroma and the
existence of the extension "GL_ARB_texture_rg").

Store this format in the vlc_gl_format, so that the sampler doesn't have
to guess by performing the same checks.

Marvin Scholz authored 3 years ago and Felix Paul Kühne committed 3 years ago

If GPL is enabled, build postproc together with ffmpeg
instead of building an ffmpeg-less ancient version with
numerous bugs.

Should fix crashes on macOS and possibly other OSes when
postproc is used.

Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This adds the vlc_xcb_Manage() call to match the behaviour of the other
XCB-based displays.

Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This uses a vout_display_t for historical reasons. We need to reuse this
code with another type of object now.